-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External events and reminders should trigger intents instead of actions #4464
Comments
It works now in Rasa X, but we have to suppress the user message somehow: |
Intent-Reminders work now! See https://github.com/RasaHQ/rasa/tree/johannes-4464. Also, to make it work in rasa shell, we need to solve Issue #4340 |
I guess you mean the event behaves like Could there be cases where it is better to not have this be directly linked to intents? Might make sense to introduce this in a major. I do not think we should have two different ways of running reminders. I'd prefer if we remove the old way and maybe try to workaround supporting existing reminders with a new system. Small remark to the story format: might consider a different indicator (e.g. |
Copy of main points from Slack discussion:
|
@tmbo @wochinge @akelad @erohmensing It would be great to get your feedback on my current plan to introduce external events. If it's fine, I'll go ahead implementing it:
I am not sure what I'll have to do about external triggers. |
@JEM-Mosig my initial thought is can we call the |
@akelad Sure, I am open to suggestions. I came up with |
Could we have |
Well but we need some way to distinguish between the events |
Like intents, external events will have to be listed in the domain file. We could require their names to be distinct from the intent names. |
I am implementing a draft now. One thing that I am unsure about is the reversed actions. I'll introduce an |
Do we actually need it right now? |
We need something like |
Adding a new In favour of the separate |
What about:
|
Summary of call
@tmbo We would create a new endpoint to trigger intents. We could also
Is that ok? |
Description of Problem:
Reminders and external events always trigger actions, which contradicts the logic that actions should be unambiguously predictable from the dialog history and present intent. For example, in the use case where a reminder is used to have the bot initiate chitchat, this makes stories unlearnable.
Overview of the Solution:
External events and reminders should trigger intents, not actions, since intents are the things that are out of our control and actions should be deterministic. Now that we have a mapping policy, this has no drawbacks.
For some applications and backwards compatibility, triggering actions should still be possible, so both options have to be available.
Examples (if relevant):
If we want to set a reminder to have the bot initiate chitchat, we would now trigger the intent, say,
EXT_remind_share_me
, which is linked to the actionutter_share_me
via theMappingPolicy
. This results in stories of the formwhich can be learned and are readable.
Definition of Done:
The text was updated successfully, but these errors were encountered: