Finish scheduler #141
Finish scheduler #141
Conversation
…/virtual-coach-server into finish-scheduler
| steps: | ||
| - intent: EXTERNAL_trigger_ask_foreseen_hrs | ||
| - action: utter_ask_foreseen_hrs |
There was a problem hiding this comment.
I couldn't get the full conversation to test successfully (i.e. with the user responding to utter_ask_foreseen_hrs). I tested manually and it works like expected.
Probably because this is an externally triggered conversation the testing suite doesn't like it. But at least we test something so I like it.
There was a problem hiding this comment.
Weird. Does Rasa actually treat intentions starting with EXTERNAL_ differently?
There was a problem hiding this comment.
Not sure if it is related to this (old-ish) issue about intent triggering vs action triggering: RasaHQ/rasa#4464 ?
There was a problem hiding this comment.
I think I made a booboo. I was about to raise an issue at Rasa, so I thought let's double check. And now it seems to work flawlessly... Thanks for having me retry this.
…/virtual-coach-server into finish-scheduler
There was a problem hiding this comment.
Good work, looks a lot cleaner now. I'm slightly perplexed by the test conversation not triggering intents correctly, so maybe we should make an issue to remember to return to that later? But it will be good to merge this as it will start affecting the e2e testing repo
| steps: | ||
| - intent: EXTERNAL_trigger_ask_foreseen_hrs | ||
| - action: utter_ask_foreseen_hrs |
There was a problem hiding this comment.
Weird. Does Rasa actually treat intentions starting with EXTERNAL_ differently?
| steps: | ||
| - intent: EXTERNAL_trigger_ask_foreseen_hrs | ||
| - action: utter_ask_foreseen_hrs |
There was a problem hiding this comment.
Not sure if it is related to this (old-ish) issue about intent triggering vs action triggering: RasaHQ/rasa#4464 ?
| @@ -19,4 +21,12 @@ services: | |||
| env_file: | |||
| - .env | |||
| expose: ["8080"] | |||
|
|
|||
| redis: | |||
There was a problem hiding this comment.
I suppose this is what is replacing django as ~db?
There was a problem hiding this comment.
No, in Cunliang's setup there was also already a redis server, that acts as a broker/message queue (I think, I'm not a celery expert (yet)). The django db was for storing the different tasks.
|
SonarCloud Quality Gate failed. |
Fixes #21
Branches of
enable-custom-channel(#140), so merge that first.