Update to embedded-hal v1.0.0 #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub fn acquire_adc<'a>(&'a self) -> crate::AdcProxy<'a, M> { | ||
| crate::AdcProxy { mutex: &self.mutex } | ||
| } | ||
| // pub fn acquire_adc<'a>(&'a self) -> crate::AdcProxy<'a, M> { |
There was a problem hiding this comment.
Could you help me understand why this section of the code is commented out, especially since the corresponding test was also removed? I’m curious whether this change addresses a particular issue or if it’s related to clean code practices.
There was a problem hiding this comment.
As I wrote this code a while ago, I don't fully remember - however I believe it is because there is no implementation of ADC or analogue pins in embedded-hal v1.0.0, whereas there was before. This code can be removed rather than commented out, I just commented it as this may be introduced in a later embedded-hal version (e.g. v1.1.0), for convinence. However deleting this may make more sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is by no means without it's difficulties - the AdcProxy struct must be dropped, as eh v1.0.0 does not contain traits for Adc, and the tests have not yet been updated - I don't have the time at this moment to implement those.