-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to avr-device 0.7 #618
Conversation
On Tue, Dec 31, 2024 at 01:29:25PM -0800, Paul Sbarra wrote:
I'm not sure why these weren't updated with the release of
`avr-device` 0.6. Since everything depending on these HALs need to
use the same `avr-device` version it seems like a good idea to keep
them synced.
Is there a good method to test this type of change locally? Trying to
run `cargo check` on the main branch results in a lot of errors.
Happy new year
|
On Wed, Jan 01, 2025 at 04:28:15AM -0800, Geert Stappers wrote:
Happy new year
In #623 did I a better attempt to express
Welcome new contributor,
please be aware that this project has currently growing pains.
Groeten
Geert Stappers
--
Silence is hard to parse
|
@tones111 FWIW I use this to bulk-compile all examples during development:
(Yes, we should add that to CI.) |
@tones111, the reason I held off upgrading to |
I usually just let CI take care of this, to be honest... That's the most dependable result one can get so I prefer it to attempting local builds. Otherwise, the suggestion from @innermatrix doesn't seem too bad.
CI is already doing a matrix build of all the example crates and for MCUs without examples, it does a simple build-test of the HAL crate with the right features. |
@Rahix Well, it doesn't right now, but one of the reasons that I am adding ATtiny xmega support to |
My motivation for this update was to allow downstream users of the HAL crates to use newer avr-device versions. Without it cargo ends up trying to link in both 0.5 and 0.6 which errors at link time due to duplicate symbols. I'll update this to depend on 0.7. update: re-push once 0.7 has been published |
47a9969
to
9e388ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
I'm not sure why these weren't updated with the release of
avr-device
0.6. Since everything depending on these HALs need to use the sameavr-device
version it seems like a good idea to keep them synced.Is there a good method to test this type of change locally? Trying to run
cargo check
on the main branch results in a lot of errors.