Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for ATmega88p #608

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Add suport for ATmega88p #608

merged 6 commits into from
Jan 7, 2025

Conversation

blueberry-fan
Copy link
Contributor

This adds support for ATmega88p.

This depends on PR Rahix/avr-device#166, though. I didn't update corresponding dependencies in cargo.toml yet.

@stappersg
Copy link
Contributor

stappersg commented Dec 3, 2024 via email

@blueberry-fan
Copy link
Contributor Author

Sorry, maybe I was too eager with this PR.
Since there is no new tag for avr-device yet, this is really pending.
Or would it be acceptable to specify a git commit as dependency?

@tones111
Copy link
Contributor

tones111 commented Jan 1, 2025

#618 should provide the avr-device version update you're dependent on, assuming @Rahix determines it to be a minor bump prior to it merging.

@Rahix
Copy link
Owner

Rahix commented Jan 6, 2025

@blueberry-fan, please rebase on latest main to pull in the new version of avr-device. Also add ATmega88P to the CI workflow so we can see whether everything builds as expected :)

@blueberry-fan
Copy link
Contributor Author

I have tried to update as requested. As this was my first contact with githubs's CI, please tell me, If I missed / messed up something.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks a lot!

@Rahix Rahix merged commit d02ab21 into Rahix:main Jan 7, 2025
26 checks passed
@blueberry-fan
Copy link
Contributor Author

Thanks for accepting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants