treewide: spi: Enforce proper CS pin usage #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahix
requested changes
Nov 17, 2020
Rahix
added
bug
Lol you don't get to say that when I mostly copied from your comment 😉 |
Haha, I did not at all remember what I wrote back then, please forgive me :D |
Rahix
approved these changes
Nov 18, 2020
| @@ -93,14 +93,13 @@ pub fn delay_us(us: u16) { | |||
| /// | |||
| /// let mut pins = arduino_leonardo::Pins::new(dp.PORTB, dp.PORTC, dp.PORTD, dp.PORTE); | |||
| /// | |||
| /// pins.led_rx.into_output(&mut pins.ddr); // Chip Select must be set to output mode. | |||
| /// | |||
| /// // Create SPI interface. | |||
| /// let mut spi = arduino_leonardo::spi::Spi::new( | |||
There was a problem hiding this comment.
Suggested change
| /// let mut spi = arduino_leonardo::spi::Spi::new( | |
| /// let (mut spi, mut cs) = arduino_leonardo::spi::Spi::new( |
Rahix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/resolves #27
Makes the proposed change to the SPI macro and the usage by ATmega328p. Waiting for review and approval before making an attempt to update all other usages.