Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to atdf2svd version 0.5.0 #170

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Update to atdf2svd version 0.5.0 #170

merged 1 commit into from
Jan 4, 2025

Conversation

Rahix
Copy link
Owner

@Rahix Rahix commented Jan 4, 2025

The new version includes Rahix/atdf2svd#67.

@Rahix
Copy link
Owner Author

Rahix commented Jan 4, 2025

Full diff of the changes: svd.diff.txt

Affected targets:

  • ATmega4809
  • ATtiny1614
  • ATtiny202
  • ATtiny212
  • ATtiny214
  • ATtiny412
  • ATtiny414
  • ATtiny416
  • ATtiny816

For each chip, for some registers, <writeConstraint>s are replaced by proper fields. Unfortunately, this is a breaking change as it makes the previously safe bits() method for those registers unsafe again:

     #[doc = "Writes raw bits to the register."]
     #[inline(always)]
-    pub fn bits(&mut self, bits: u8) -> &mut Self {
-        unsafe { self.0.bits(bits) };
+    pub unsafe fn bits(&mut self, bits: u8) -> &mut Self {
+        self.0.bits(bits);
         self
     }

@Rahix Rahix marked this pull request as ready for review January 4, 2025 20:32
@Rahix Rahix added the dependencies Pull requests that update a dependency file label Jan 4, 2025
@Rahix Rahix merged commit 3eeb76e into main Jan 4, 2025
2 checks passed
@Rahix Rahix deleted the new-atdf2svd branch January 4, 2025 20:37
@Rahix Rahix mentioned this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant