Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle register with mode as child #67

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Conversation

flobz
Copy link
Contributor

@flobz flobz commented Oct 28, 2024

Improve handling of atmega4809.atfd
Required for Rahix/avr-hal#97

@Rahix
Copy link
Owner

Rahix commented Oct 28, 2024

Please check the CI failures.

@flobz flobz force-pushed the feature/atmega4809 branch from 4ad063f to 6fde7d7 Compare October 29, 2024 06:24
@flobz
Copy link
Contributor Author

flobz commented Oct 29, 2024

Please check the CI failures.

It should be fix.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! I have a few minor review comments, see below.

From my understanding, this shouldn't change any existing register/field descriptions, it should just be adding new fields from the modes in the ATDF, right?

Also, just need to say this: I really really appreciate that you split this PR into two commits such that the changes to the generated SVD snapshot are visible in the diff of the second commit. This makes understanding the effects so much easier and not many people are willing to put this much effort in. Thanks :)

src/atdf/field.rs Outdated Show resolved Hide resolved
src/atdf/field.rs Outdated Show resolved Hide resolved
src/atdf/register.rs Outdated Show resolved Hide resolved
src/atdf/register.rs Outdated Show resolved Hide resolved
@flobz
Copy link
Contributor Author

flobz commented Nov 3, 2024

Thanks for all your feedbacks, I appreciate !

From my understanding, this shouldn't change any existing register/field descriptions, it should just be adding new fields from the modes in the ATDF, right?

Yes, that's right. For example, it will add the NORMAL_CHSIZE bitfield, which is required for USART on Arduino nano every as you can see here.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@Rahix Rahix merged commit 50fc209 into Rahix:main Nov 3, 2024
2 checks passed
@flobz
Copy link
Contributor Author

flobz commented Nov 4, 2024

Thanks for merging, do you plan to do a new release of atdf2svd and avr-device soon ?

@Rahix
Copy link
Owner

Rahix commented Nov 4, 2024

Just took care of the atdf2svd release, will do avr-device in the coming days.

@flobz
Copy link
Contributor Author

flobz commented Nov 26, 2024

@Rahix would you able to do an avr-device release soon ? 😄

@Rahix
Copy link
Owner

Rahix commented Jan 4, 2025

Just a heads up, your changes have hit avr-device main branch so they are pending for the next release which is hopefully not far off :)

@Rahix
Copy link
Owner

Rahix commented Jan 6, 2025

And here's the release: https://github.com/Rahix/avr-device/releases/tag/v0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants