-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle register with mode as child #67
Conversation
Please check the CI failures. |
4ad063f
to
6fde7d7
Compare
It should be fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution! I have a few minor review comments, see below.
From my understanding, this shouldn't change any existing register/field descriptions, it should just be adding new fields from the modes in the ATDF, right?
Also, just need to say this: I really really appreciate that you split this PR into two commits such that the changes to the generated SVD snapshot are visible in the diff of the second commit. This makes understanding the effects so much easier and not many people are willing to put this much effort in. Thanks :)
Thanks for all your feedbacks, I appreciate !
Yes, that's right. For example, it will add the NORMAL_CHSIZE bitfield, which is required for USART on Arduino nano every as you can see here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Thanks for merging, do you plan to do a new release of atdf2svd and avr-device soon ? |
Just took care of the atdf2svd release, will do avr-device in the coming days. |
@Rahix would you able to do an avr-device release soon ? 😄 |
Just a heads up, your changes have hit |
And here's the release: https://github.com/Rahix/avr-device/releases/tag/v0.7.0 |
Improve handling of atmega4809.atfd
Required for Rahix/avr-hal#97