Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Timer Finished Text #72

Closed
DEEKAYR opened this issue Jul 5, 2021 · 2 comments · Fixed by #89
Closed

Custom Timer Finished Text #72

DEEKAYR opened this issue Jul 5, 2021 · 2 comments · Fixed by #89
Labels
feature request New feature or request

Comments

@DEEKAYR
Copy link

DEEKAYR commented Jul 5, 2021

Hello maybe 0 should say lobby starting since you know the timer is done but maybe? Maybe have it as option to input custom text when timer hit zero for customizartion like in need for speed underground 2 thanks

@RVRX RVRX added the feature request New feature or request label Jul 5, 2021
@RVRX RVRX added this to the Full Release milestone Jul 5, 2021
@RVRX
Copy link
Owner

RVRX commented Jul 10, 2021

this feature will not be included in v1.0 release but may be added in subsequent updates, say when working on #12 and when cleaning the timer class

@RVRX RVRX removed this from the Full Release milestone Jul 10, 2021
@RVRX RVRX changed the title Lobby timer 0 Custom Timer Finished Text Jul 11, 2021
RVRX added a commit that referenced this issue Jul 16, 2021
@RVRX
Copy link
Owner

RVRX commented Jul 16, 2021

Current implementation as of e60c2be, behaves as such:
When timer naturally reaches 0, custom text is applied.
When timer is stopped (from a play, paused, or stop state), the displayed text is 0:00.

Therefore, a timer with custom text can always be overwritten to 0:00 by pressing stop.
The alternative, would be to have the stop button also display the custom text, OR could have a preference in settings deciding how the user would like the stop button to behave

image

NOTE: In-app preview does not display the custom text as of the aforementioned commit e60c2be

@RVRX RVRX pinned this issue Jul 18, 2021
@RVRX RVRX linked a pull request Jul 21, 2021 that will close this issue
@RVRX RVRX mentioned this issue Jul 21, 2021
@RVRX RVRX closed this as completed in #89 Jul 21, 2021
@RVRX RVRX unpinned this issue Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants