Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename current timer class and add actual custom timer setup #41

Closed
RVRX opened this issue Jun 27, 2021 · 6 comments
Closed

Rename current timer class and add actual custom timer setup #41

RVRX opened this issue Jun 27, 2021 · 6 comments
Labels
feature request New feature or request

Comments

@RVRX
Copy link
Owner

RVRX commented Jun 27, 2021

A second timer so we have a "Custom" and a "Lobby". Custom timer can have easier to see setter, and the lobby can have a more permanent length

@RVRX RVRX added the feature request New feature or request label Jun 27, 2021
@RVRX
Copy link
Owner Author

RVRX commented Jun 29, 2021

renamed class in 2855f7f

@RVRX
Copy link
Owner Author

RVRX commented Jun 29, 2021

Should the custom timer also write to the timer.txt file, or a different one? Maybe let the user choose in settings?

RVRX added a commit that referenced this issue Jun 29, 2021
need to decide how to proceed from here
@RVRX RVRX added this to the Full Release milestone Jul 3, 2021
@RVRX
Copy link
Owner Author

RVRX commented Jul 9, 2021

I think the solution will be to have one set of timer controls on the page. However, there will be two input boxes; one for the 'lobby timer' and the other for the 'custom timer' (would probably just op to name them timer 1 & 2, as there is no need to associate one or the other with its task). Timer lengths can be moved to a preference based system, as this is something a user might prefer to hang around between folder changes

@RVRX RVRX pinned this issue Jul 9, 2021
@RVRX
Copy link
Owner Author

RVRX commented Jul 9, 2021

see #72

RVRX added a commit that referenced this issue Jul 9, 2021
@RVRX
Copy link
Owner Author

RVRX commented Jul 9, 2021

image

@RVRX
Copy link
Owner Author

RVRX commented Jul 9, 2021

I think some changes might need to be made to make this page look a little better and increase its clarity, but for now it's looking okay. And of course the Timer back-end is a wreck rn as it still contains code for the intended separation of the lobby and custom timer. The Lobby Timer class is the one being used currently, and the custom timer will probably be removed in future.

@RVRX RVRX closed this as completed Jul 9, 2021
@RVRX RVRX unpinned this issue Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant