-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover VBL Addition #4299
Cover VBL Addition #4299
Conversation
This is a more complicated contribution than my first, so while I think its acceptable, I've got it in draft to allow for some commentary/feedback first. |
So this is basically a one may mirror? If so it works like hill-vbl but also supports lines. Maybe it could be foldet into it? |
More like pit-opposite. Pits can be seen into from outside, but can't be seen out of. |
src/main/java/net/rptools/maptool/client/ui/zone/vbl/VisionBlockingAccumulator.java
Outdated
Show resolved
Hide resolved
src/main/resources/net/rptools/maptool/language/i18n_uk.properties
Outdated
Show resolved
Hide resolved
a00ab06
to
b120c00
Compare
src/main/java/net/rptools/maptool/client/ui/zone/vbl/VisionBlockingAccumulator.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/net/rptools/maptool/client/ui/zone/vbl/VisionBlockingAccumulator.java
Sometimes I really struggle with git and merging upstream changes back into my fork -.- |
Identify the Bug or Feature request
Adds Cover VBL
closes #3732
Description of the Change
Adds cover VBL to available vision options.
Tokens outside cover cannot see into it - effectively identical to wall.
Tokens inside cover see out of it - effectively nonexistent.
Possible Drawbacks
Limited use? Unwanted? Complicates colours of VBL view.
Documentation Notes
The Hero Cannot See into Cover
The Troll in Cover, is unaffected, and can see the Hero outside.
Release Notes
This change is