Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover VBL Addition #4299

Merged
merged 16 commits into from
Nov 3, 2023
Merged

Cover VBL Addition #4299

merged 16 commits into from
Nov 3, 2023

Conversation

ColdAnkles
Copy link
Contributor

@ColdAnkles ColdAnkles commented Sep 23, 2023

Identify the Bug or Feature request

Adds Cover VBL
closes #3732

Description of the Change

Adds cover VBL to available vision options.

Tokens outside cover cannot see into it - effectively identical to wall.
Tokens inside cover see out of it - effectively nonexistent.

Possible Drawbacks

Limited use? Unwanted? Complicates colours of VBL view.

Documentation Notes

The Hero Cannot See into Cover
image

The Troll in Cover, is unaffected, and can see the Hero outside.
image

Release Notes

  • Added Cover VBL

This change is Reviewable

@ColdAnkles
Copy link
Contributor Author

This is a more complicated contribution than my first, so while I think its acceptable, I've got it in draft to allow for some commentary/feedback first.

@kwvanderlinde kwvanderlinde self-requested a review September 23, 2023 07:19
@thelsing
Copy link
Collaborator

So this is basically a one may mirror? If so it works like hill-vbl but also supports lines. Maybe it could be foldet into it?
The question is how do you see wich side you can see through from.
I think draft-PRs are only necessary if you don't want the PR merged yet. If you think it could be merged just use a normal PR. IMO people will be more likely to look at "real" PRs.

@ColdAnkles
Copy link
Contributor Author

More like pit-opposite. Pits can be seen into from outside, but can't be seen out of.
This you can't see into from outside, but can see out of.

@ColdAnkles ColdAnkles marked this pull request as ready for review September 26, 2023 09:10
@cwisniew cwisniew added the feature Adding functionality that adds value label Oct 19, 2023
@ColdAnkles
Copy link
Contributor Author

Sometimes I really struggle with git and merging upstream changes back into my fork -.-

@cwisniew cwisniew added this pull request to the merge queue Nov 3, 2023
Merged via the queue into RPTools:develop with commit d4961f7 Nov 3, 2023
4 checks passed
@ColdAnkles ColdAnkles deleted the cover-vbl branch November 4, 2023 09:48
@kwvanderlinde
Copy link
Collaborator

Took this for a spin, there's one edge case that is not working as I would expect: a token in cover will have its vision blocked by the opposite side of an enclosed ocean (hole):
image

Compare with the case where the "hole" is not completely enclosed, then vision is not obstructed at all:
image

I would expect the first case to also not block vision either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Development

Successfully merging this pull request may close these issues.

[Feature]: New VBL - Cover
4 participants