Fix emulator crash when stopping emulation after being paused #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
changed the title
Megamouse
reviewed
Mar 25, 2023
| Resume(); // TODO: Prevent pausing by other threads while in this loop | ||
|
|
||
| // TODO: Prevent pausing by other threads while in this loop | ||
| CallFromMainThread([this]() |
There was a problem hiding this comment.
std::thread cannot execute BlockingCallFromMainThread which is present inside Resume().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockingCallFromMainThread has been called on std::thread inside Resume() resultiing in a verification failure.