Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HipTensor Benchmarking Overhaul #276

Merged
merged 20 commits into from
Oct 22, 2024
Merged

Conversation

dlangbe
Copy link
Collaborator

@dlangbe dlangbe commented Oct 7, 2024

Includes changes from 271 and 273 with additional fixes for printout formatting and controlled header printing.

library/src/hiptensor_options.cpp Show resolved Hide resolved
library/src/hiptensor_options.cpp Show resolved Hide resolved
scripts/performance/BenchmarkPermutation.sh Outdated Show resolved Hide resolved
test/03_reduction/reduction_test.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking great so far. Should be good after the feedbacks are addressed

@cgmillette cgmillette mentioned this pull request Oct 22, 2024
cgmillette
cgmillette previously approved these changes Oct 22, 2024
Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgmillette cgmillette merged commit e247c72 into ROCm:develop Oct 22, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants