Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking Scripts #268

Closed
wants to merge 1 commit into from
Closed

Conversation

dlangbe
Copy link
Collaborator

@dlangbe dlangbe commented Sep 13, 2024

Added scripts to perform benchmarking of all hipTensor test types

Copy link
Collaborator

@cgmillette cgmillette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@CongMa13 CongMa13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


output_dir=hiptensor-benchmarks
build_dir=../../build/bin/
config_dir=../../test/01_contraction/configs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found that there are some new files added in another commit

test/01_contraction/configs/bench/bilinear_test_params_rank1.yaml

Are they going to be used in benchmark scripts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Benchmarks probably won't cover so much parameter space, but have more emphasis on performance and regression checks.

@cgmillette
Copy link
Collaborator

Superseded by #276

@cgmillette cgmillette closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants