Develop #188
Merged
Develop #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pplied in robotis_def.h
…d c++: unistd.h was missing
* added "serial" library dependency in setup.py * simplified some code * fixed some bugs * removed error parameter, because in Python integers are immutable values and if modified inside * functions, the new value will no more be tied to the outer scope * renamed id to dxl_id, as id is a python builtin * removed unnecessary deallocations (Python has a garbage collector)
- fixed syntax "not _ in" as "_ not in" - removed not needed variable declaration - removed not needed local list cleanup - fixed PEP8 spacing rules - renamed "id" params (python dislikes the custom use of "id" name) - propagate fixes from port_handler_linux to win and mac versions Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
reg_write was using a wrong size for its txpacket action seems to require RX after some tests on real hardware Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Second round of fixes for Python implementation
Added missing header file for reset and factory_reset examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.6.0 (2018-03-16)