fix(routing): iOS swipe back on settings page #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit it was impossibile to run the app on iOS, due to outdated **Podfile**. After this commit it's possible to run the app correctly on iOS devices.
Before this commit the Settings Page was not considered as a route, instead all the content of the page was replacing the content below, since the `_notTransitionPageRoute()` method was used to "push" the route. After this commit to push the route the `_cupertinoPageRoute()` method is being used. With that edit the Settings Page is treated like a normal route, and so it's possible to swipe back and navigate correctly to the route. Closes: RIP-Comm#218
fres-sudo
force-pushed
the
fix-swipe-back-ios
branch
from
d50b94c to
deb9fc2
Compare
lucaantonelli
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the issue of the routing system for the Settings Page.
Before this PR the Settings Page was not considered as a route, instead all the content of the page was replacing the content below, since the
_notTransitionPageRoute()method was used to "push" the route.After this commit to push the route the
_cupertinoPageRoute()method is being used. With that edit the Settings Page is treated like a normal route, and so it's possible to swipe back and navigate correctly to the route.Closes: #218