Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Swipe back action doesn’t work in settings #218

Closed
federicopozzato opened this issue Feb 19, 2025 · 1 comment · Fixed by #229
Closed

iOS: Swipe back action doesn’t work in settings #218

federicopozzato opened this issue Feb 19, 2025 · 1 comment · Fixed by #229
Assignees
@fres-sudo
Labels
frontend This is frontend related good first issue Good for newcomers iOS
Milestone
1.0 Stable

Comments

@federicopozzato
Copy link
Contributor

When I’m in the settings page, the “swipe back” action doesn’t work
@mikev-cw mikev-cw added good first issue Good for newcomers frontend This is frontend related labels Feb 19, 2025
@theperu theperu added the iOS label Feb 22, 2025
@theperu theperu added this to the 1.0 Stable milestone Feb 22, 2025
@fres-sudo
Copy link
Contributor

I would like to work on it if you assign it to me!

fres-sudo added a commit to fres-sudo/sossoldi that referenced this issue Feb 26, 2025
@fres-sudo
fix(routing): settings page routing
d50b94c 
Before this commit the Settings Page was not considered as a route,
instead all the content of the page was replacing the content below,
since the `_notTransitionPageRoute()` method was used to "push" the
route.

After this commit to push the route the `_cupertinoPageRoute()` method
is being used. With that edit the Settings Page is treated like a normal
route, and so it's possible to swipe back and navigate correctly to the
route.

Closes: RIP-Comm#218
@fres-sudo fres-sudo mentioned this issue Feb 26, 2025
Merged
fres-sudo added a commit to fres-sudo/sossoldi that referenced this issue Feb 26, 2025
@fres-sudo
fix(routing): settings page routing
deb9fc2 
Before this commit the Settings Page was not considered as a route,
instead all the content of the page was replacing the content below,
since the `_notTransitionPageRoute()` method was used to "push" the
route.

After this commit to push the route the `_cupertinoPageRoute()` method
is being used. With that edit the Settings Page is treated like a normal
route, and so it's possible to swipe back and navigate correctly to the
route.

Closes: RIP-Comm#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fres-sudo fres-sudo

Labels
frontend This is frontend related good first issue Good for newcomers iOS
Projects
None yet
Milestone
1.0 Stable
Development

Successfully merging a pull request may close this issue.

fix(routing): iOS swipe back on settings page fres-sudo/sossoldi
4 participants
@theperu @federicopozzato @fres-sudo @mikev-cw