Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/ucglib: improve build system integration #14273

Merged
merged 1 commit into from
Jun 16, 2020
Merged

pkg/ucglib: improve build system integration #14273

merged 1 commit into from
Jun 16, 2020

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Jun 12, 2020

And leave the original repository untouched (except for patches)

Contribution description

This PR reworks a bit the integration of the ucglib package in the build system. Its goal is to avoid copying files in the cloned repository and better use RIOT modules.
Except for the applied patch, the cloned repository is now kept untouched.

Testing procedure

  • A green Murdock
  • tests/pkg_ucglib is still working

Issues/PRs references

None

@aabadie aabadie added Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 12, 2020
@aabadie aabadie requested a review from basilfx as a code owner June 12, 2020 07:19
@aabadie aabadie force-pushed the pr/pkg/ucglib_make branch 3 times, most recently from 89982a8 to c183947 Compare June 12, 2020 11:06
@aabadie
pkg/ucglib: clean build system integration
0fc0ad7 
And leave the original repository untouched (except for patches)
@aabadie aabadie force-pushed the pr/pkg/ucglib_make branch from c183947 to 0fc0ad7 Compare June 12, 2020 15:55
@aabadie aabadie mentioned this pull request Jun 15, 2020
Merged
@aabadie aabadie changed the title pkg/ucglib: clean build system integration pkg/ucglib: improve build system integration Jun 16, 2020
basilfx
basilfx approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@basilfx basilfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are similar to #14257.

Tested this with a SSD1331 on a STK3600. No impact.

@basilfx basilfx merged commit 3d4a330 into RIOT-OS:master Jun 16, 2020
@aabadie aabadie deleted the pr/pkg/ucglib_make branch June 17, 2020 06:17
@aabadie
Copy link
Contributor Author

aabadie commented Jun 17, 2020

Thanks for reviewing and merging @basilfx !

@miri64 miri64 added this to the Release 2020.07 milestone Jun 24, 2020
@miri64 miri64 added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basilfx basilfx basilfx approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @basilfx @miri64