Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14_SD_BELL - fixed repeats #593

Merged
merged 2 commits into from
Jun 7, 2019
Merged

14_SD_BELL - fixed repeats #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbea8ef
14_SD_BELL - fixed repeats
HomeAutoUser May 27, 2019
47087de
Merge branch 'dev-r34' into dev-r34_SD_BELL
HomeAutoUser Jun 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGED
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
01.06.2019
14_SD_BELL.pm: fixed repeats model Heidemann_|_Heidemann_HX_|_VTX-BELL (https://github.com/RFD-FHEM/RFFHEM/issues/367#issuecomment-493764470)
20.05.2019
SD_ProtocolData.pm: improved OpusXT300
18.05.2019
Expand Down
15 changes: 11 additions & 4 deletions FHEM/14_SD_BELL.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
##############################################################################
# $Id: 14_SD_BELL.pm 32 2018-12-29 14:00:00 v3.3.3-dev_08.12. $HomeAuto_User
# $Id: 14_SD_BELL.pm 18657 2019-02-19 21:02:24Z HomeAuto_User $
#
# The file is part of the SIGNALduino project.
# The purpose of this module is to support many wireless BELL devices.
Expand Down Expand Up @@ -184,7 +184,12 @@ sub Set($$$@) {

my $msg = "P$protocol#" . $bitData;

$msg .= "#R$repeats";
if ($model eq "Heidemann_|_Heidemann_HX_|_VTX-BELL") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die Bezeichnung von model sieht seltsam aus. Ist die wirklich so lang und "seltsam" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, die Bezeichnung ist schon seit Beginn so.

$msg .= "#R135";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hast Du mal nachgerechnet ob das die maximale Sendezeit einhält?

Copy link
Contributor Author

@HomeAutoUser HomeAutoUser Jun 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenn ich richtig gerechnet habe

0.017906 Sekunden
2.41731 Sekunden with 135 repeats

Grundlage

SR;;R=135;;P0=-5209;;P1=365;;P2=-325;;P3=692;;P4=-668;;D=01412323414141412341414123;;

#367 (comment)

Dies bedeutet demnach, daß beim set ring ein repeat von mindestens ca 70 notwendig ist.

Um unter 2 Sekunden zu bleiben, würde ich ggf noch mit R110 "mitgehen".

SR;;R=110;;P0=-5209;;P1=365;;P2=-325;;P3=692;;P4=-668;;D=01412323414141412341414123;;

0.017906 Sekunden
1.96966 Sekunden with 110 repeats

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

immerhin, aber trotzdem das sind Welten für so einen Microcontroller?
Wie kamt ihr denn darauf, dass so viele Wiederholungen nötig sind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#367 (comment)

dazugehöriger Faden + User

} else {
$msg .= "#R$repeats";
}

Log3 $name, 3, "$ioname: $name sendMsg=$msg";

if ($cmd ne "?") {
Expand Down Expand Up @@ -426,7 +431,8 @@ sub Attr(@) {
<li>model<br>
The attribute indicates the model type of your device.<br></li></ul>
<ul><li><a name="repeats"></a>repeats<br>
This attribute can be used to adjust how many repetitions are sent. Default is 5.</li></ul><br>
This attribute can be used to adjust how many repetitions are sent. Default is 5.<br>
<i>(For the model Heidemann_|_Heidemann_HX_|_VTX-BELL, the value repeats is fixed at 135!)</i></li></ul><br>
<br>
</ul>
=end html
Expand Down Expand Up @@ -471,7 +477,8 @@ sub Attr(@) {
<li>model<br>
Das Attribut bezeichnet den Modelltyp Ihres Ger&auml;tes.<br></li></ul>
<ul><li><a name="repeats"></a>repeats<br>
Mit diesem Attribut kann angepasst werden, wie viele Wiederholungen sendet werden. Standard ist 5.</li></ul><br>
Mit diesem Attribut kann angepasst werden, wie viele Wiederholungen sendet werden. Standard ist 5.<br>
<i>(Bei dem Model Heidemann_|_Heidemann_HX_|_VTX-BELL ist der Wert repeats fest auf 135 gesetzt unabhäning vom eingestellten Attribut!)</i></li></ul><br>
<br>
</ul>
=end html_DE
Expand Down