-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14_SD_BELL - fixed repeats #593
Conversation
HomeAutoUser
commented
May 27, 2019
- Please check if the PR fulfills these requirements
- Tests for the changes have been added / modified (needed for for bug fixes / features)
- commandref has been added / updated (needed for bug fixes / features)
- CHANGED has been updated (needed for bug fixes / features)
- What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
- user can not send with modul
- What is the current behavior? (You can also link to an open issue here)
- fix repeats for model Heidemann_|Heidemann_HX|_VTX-BELL ME Funkklingel #367 (comment)
- added fix repeats for model Heidemann_|_Heidemann_HX_|_VTX-BELL RFD-FHEM#367 (comment)
@@ -184,7 +184,12 @@ sub Set($$$@) { | |||
|
|||
my $msg = "P$protocol#" . $bitData; | |||
|
|||
$msg .= "#R$repeats"; | |||
if ($model eq "Heidemann_|_Heidemann_HX_|_VTX-BELL") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Die Bezeichnung von model sieht seltsam aus. Ist die wirklich so lang und "seltsam" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja, die Bezeichnung ist schon seit Beginn so.
@@ -184,7 +184,12 @@ sub Set($$$@) { | |||
|
|||
my $msg = "P$protocol#" . $bitData; | |||
|
|||
$msg .= "#R$repeats"; | |||
if ($model eq "Heidemann_|_Heidemann_HX_|_VTX-BELL") { | |||
$msg .= "#R135"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hast Du mal nachgerechnet ob das die maximale Sendezeit einhält?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wenn ich richtig gerechnet habe
0.017906 Sekunden
2.41731 Sekunden with 135 repeats
Grundlage
SR;;R=135;;P0=-5209;;P1=365;;P2=-325;;P3=692;;P4=-668;;D=01412323414141412341414123;;
Dies bedeutet demnach, daß beim set ring ein repeat von mindestens ca 70 notwendig ist.
Um unter 2 Sekunden zu bleiben, würde ich ggf noch mit R110 "mitgehen".
SR;;R=110;;P0=-5209;;P1=365;;P2=-325;;P3=692;;P4=-668;;D=01412323414141412341414123;;
0.017906 Sekunden
1.96966 Sekunden with 110 repeats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
immerhin, aber trotzdem das sind Welten für so einen Microcontroller?
Wie kamt ihr denn darauf, dass so viele Wiederholungen nötig sind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dazugehöriger Faden + User
Um welche maximale Sendezeit geht es hier eigentlich und woher stammt die Angabe von max. 2 Sekunden dafür? |
Ich habe jetzt auf die Schnelle nichts belastbares gefunden. Mit war so, dass es eine 1% Regel pro Stunde gibt. |
Das gilt aber nur für 868 MHz und da ist es auch noch verschieden je nach Kanal. Geeignete Suchbegriffe sind "duty cycle ism". |