Fix logging sometimes not working #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeckoEidechse
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
Checking diff with 85a2fb9...e127844#diff-ced5e6062a6f1fc1a63df5e689c1d6f86e40423b52da4f15eedd1aae283cbc46 and this is basically just a small logic change when comparing those two states.
Not much to code review here
GeckoEidechse
added
needs testing
|
Running with this change seems to fix the issue. I could not recreate it with about 20 starts |
RoyalBlue1
approved these changes
Jul 28, 2024
GeckoEidechse
removed
needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #752
reverts #741 and removes the log line since it was originally just added as a precaution