Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for Console Window before allocating one #741

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Check for Console Window before allocating one #741

merged 2 commits into from
Jun 27, 2024

Conversation

Jan200101
Copy link
Contributor

gets rid of that annoying
[*] Failed to create a console window, maybe a console already exists?
when launching via NorthstarLauncher.exe

@Jan200101 Jan200101 added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Jun 27, 2024
catornot
catornot approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@catornot catornot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very simple change 👍
no more failed to create a console window :))))

@Jan200101 Jan200101 added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs code review Changes from PR still need to be reviewed in code labels Jun 27, 2024
@GeckoEidechse
Copy link
Member

Merging based on review

@GeckoEidechse GeckoEidechse merged commit f29823a into R2Northstar:main Jun 27, 2024
4 checks passed
@Jan200101 Jan200101 deleted the PR/check-console branch June 28, 2024 07:16
@ASpoonPlaysGames ASpoonPlaysGames mentioned this pull request Jul 25, 2024
Closed
ASpoonPlaysGames added a commit to ASpoonPlaysGames/NorthstarLauncher that referenced this pull request Jul 27, 2024
@ASpoonPlaysGames
Revert R2Northstar#741 and remove log message since it's not a big deal
e127844
@ASpoonPlaysGames ASpoonPlaysGames mentioned this pull request Jul 27, 2024
Merged
GeckoEidechse pushed a commit that referenced this pull request Jul 28, 2024
@ASpoonPlaysGames
Fix logging sometimes not working (#754)
c405583 
Revert #741 and remove log message since it's not a big deal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catornot catornot catornot approved these changes

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs testing Changes from the PR still need to be tested
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jan200101 @GeckoEidechse @catornot