Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the tests/testdata files to tests/testthat/_data and package them #170

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Copy the tests/testdata files to tests/testthat/_data and package them #170

merged 1 commit into from
Aug 23, 2024

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Aug 23, 2024

The new directory is now being included into the package (with exclusion of SPEfile.SPE as much larger than the rest). File BINfile.V8.binx is not copied as an identical file is already under inst/extdata and that's what is already being used in the read_BIN2R() tests. Part of #168.

This is a preliminary step before the tests/testdata directory can be removed and the test files updated (#169).

The new directory is now being included into the package (with exclusion
of SPEfile.SPE as much larger than the rest). File BINfile.V8.binx is not
copied as an identical file is already under inst/extdata and that's what
is already being used in the read_BIN2R() tests.

This is a preliminary step before the tests/testdata directory can be
removed and the test files updated.
@mcol mcol changed the title Copy the tests/testdata files to tests/testthat/data and package them Copy the tests/testdata files to tests/testthat/_data and package them Aug 23, 2024
@mcol
Copy link
Contributor Author

mcol commented Aug 23, 2024

Using data as directory name caused some tests to fail, so I've renamed it to _data (for similarity to the _snaps directory that testthat generates).

@RLumSK RLumSK merged commit cd36684 into R-Lum:dev_0.9.x Aug 23, 2024
10 checks passed
@mcol mcol deleted the issue_168_pre branch August 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants