Include testthat/data into the package and update tests to refer to it #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLumSK
approved these changes
Aug 23, 2024
|
@mcol The CI tests fail, can you please double-check. |
|
#170 has to go in first, then I can rebase and update this. |
…stdata. This modifies the tests that used to download files from github to refer directly to the new local path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the test files that were in the
tests/testdatadirectory to thetests/testthat/datadirectory, so they can be found bytestthat. Now these files (with the exception ofSPEfile.SPE) are included into the package, and tests that used to download those file from github to refer directly to the new local path (apart from one case for coverage). Fixes #168.File
tests/testdata/BINfile_V8.binxis removed as an identical file is already underinst/extdataand that's what was already being used in theread_BIN2R()tests.