Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth implementation #93

Closed
wants to merge 1 commit into from
Closed

Conversation

kelindar
Copy link

I added support for Marathon Basic Auth, using two environment variables that can be set:

  • MARATHON_USERNAME
  • MARATHON_PASSWORD

I haven't extensively tested this yet, but it is important for people (like us) who expose marathon REST API to the world with basic auth.

@j1n6
Copy link
Contributor

j1n6 commented Mar 22, 2015

Thanks! This is really good to have!
This will be tested and reviewed.

On 22 Mar 2015, at 14:32, Roman Atachiants notifications@github.com wrote:

I added support for Marathon Basic Auth, using two environment variables
that can be set:

  • MARATHON_USERNAME
  • MARATHON_PASSWORD

I haven't extensively tested this yet, but it is important for people (like

us) who expose marathon REST API to the world with basic auth.

You can view, comment on, or merge this pull request online at:

#93
Commit Summary

  • auth implementation

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#93.

@xiaods
Copy link

xiaods commented Apr 3, 2015

cool!

@j1n6
Copy link
Contributor

j1n6 commented Jul 3, 2015

Looks good. I will merge as soon as this is rebased.

@brugidou
Copy link

brugidou commented Aug 4, 2015

It should be merged with #141

@KidkArolis
Copy link

Cleaning up PRs. Feel free to reopen if still relevant.

@KidkArolis KidkArolis closed this Aug 24, 2016
@j1n6 j1n6 reopened this Sep 1, 2016
@j1n6
Copy link
Contributor

j1n6 commented Sep 2, 2016

Closed by #141

@j1n6 j1n6 closed this Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants