add optional HTTP basic authentication

[bacoboy]

If your Marathon endpoint is authenticated, Bamboo needs to pass Username/Password.
This simple implementation uses the built-in Go net/http SetBasicAuth() if both the user & password are specified.

[j1n6]

Hi, thanks for the PR.
I just need to run a few tests, otherwise this look good.

We are moving offices, please expecting slow responses from me.

On 25 Jun 2015, at 21:59, Steve Hoffman notifications@github.com wrote:

If your Marathon endpoint is authenticated, Bamboo needs to pass Username/Password.
This simple implementation uses the built-in Go net/http SetBasicAuth() if both the user & password are specified.

You can view, comment on, or merge this pull request online at:

#141

Commit Summary

add optional HTTP basic authentication
File Changes

M README.md (2)
M configuration/configuration.go (2)
M configuration/marathon.go (2)
M main/bamboo/bamboo.go (3)
Patch Links:

https://github.com/QubitProducts/bamboo/pull/141.patch
https://github.com/QubitProducts/bamboo/pull/141.diff
—
Reply to this email directly or view it on GitHub.

[bacoboy]

Just checking in a month later. How'd the move go?

[j1n6]

Your PR looks good. The move was fun and new office is really nice!
If you are around central London, I would love to invite you.

Thanks for the PR.

[bacoboy]

Great. Any idea when a point release can be cut? We have somebody here waiting to use it and would like to use the official version over my fork.

Thanks. And if I'm in London I might just take you up on that. Always looking for a reason to grab a cider!

[j1n6]

Just made a release. :)

[bacoboy]

Sweet. I'll check it out. Thanks!

[j1n6]

@bacoboy We are at MesosConf. Let me if you would like to meet up :P

[bacoboy]

Sure! DM me on Twitter @bacoboy. What's your handle?

[j1n6]

My handle is @activars

We can catchup in the event this evening.

On 20 Aug 2015, at 17:49, Steve Hoffman notifications@github.com wrote:

Sure! DM me on Twitter @bacoboy. What's your handle?

—
Reply to this email directly or view it on GitHub.