Remove useless pylint suppressions #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levbishop
requested review from
a team,
ikkoham,
t-imamichi,
nonhermitian,
alexanderivrii,
ShellyGarion,
eggerdj,
wshanks,
jyu00,
manoelmarques,
woodsp-ibm and
ElePT
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4305374899
💛 - Coveralls |
jakelishman
approved these changes
Mar 1, 2023
Comment on lines
-136
to
+137
| options.hello = "world" # pylint: disable=assigning-non-slot | ||
| options.a = "b" # pylint: disable=assigning-non-slot | ||
| options.hello = "world" | ||
| options.a = "b" |
There was a problem hiding this comment.
This was a bug in Pylint that I wrote the fix for - happy to see us being able to remove the suppression!
jakelishman
added
type: qa
|
I'm not backporting this because it won't have an effect on CI, and I suspect it likely has conflicts that we don't really need to deal with. |
Eric-Arellano
approved these changes
Mar 1, 2023
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms
that referenced
this pull request
Jul 27, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-provider
that referenced
this pull request
Oct 4, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-runtime
that referenced
this pull request
Oct 10, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Oct 12, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-runtime
that referenced
this pull request
Dec 8, 2023
* Switch to pyproject.toml no config changes * Remove trivial differences from default * Fall back to a few additional defaults * Remove useless pylint suppressions * Reblacken --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #9644.
With the move to the newer version of pylint in #9615 and the pylint config simplification in #9644 it seemed worth making a pass to remove pylint suppressions that have become unnecessary due to pylint improvement, config relaxation or removal of the underlying issue through code cleanup.
This PR removes about half of the non-
cyclic-importsuppressions, so it should make any transition to other lint tools (eg ruff #9631) simpler