Remove useless pylint suppressions (Qiskit#9697)

* Switch to pyproject.toml no config changes

* Remove trivial differences from default

* Fall back to a few additional defaults

* Remove useless pylint suppressions

* Reblacken

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

qiskit/algorithms/amplitude_estimators/ae.py

@@ -98,7 +98,7 @@ def __init__(
             self.quantum_instance = quantum_instance
 
         # get parameters
-        self._m = num_eval_qubits  # pylint: disable=invalid-name
+        self._m = num_eval_qubits
         self._M = 2**num_eval_qubits  # pylint: disable=invalid-name
 
         self._iqft = iqft

qiskit/algorithms/amplitude_estimators/estimation_problem.py

@@ -201,7 +201,6 @@ def rescale(self, scaling_factor: float) -> "EstimationProblem":
 
         # add the scaling qubit to the good state qualifier
         def is_good_state(bitstr):
-            # pylint: disable=not-callable
             return self.is_good_state(bitstr[1:]) and bitstr[0] == "1"
 
         # rescaled estimation problem

qiskit/algorithms/eigen_solvers/numpy_eigen_solver.py

@@ -28,9 +28,6 @@
 logger = logging.getLogger(__name__)
 
 
-# pylint: disable=invalid-name
-
-
 class NumPyEigensolver(Eigensolver):
     r"""
     Pending deprecation: NumPy Eigensolver algorithm.

qiskit/algorithms/eigensolvers/numpy_eigensolver.py

@@ -29,7 +29,6 @@
 from ..list_or_dict import ListOrDict
 
 logger = logging.getLogger(__name__)
-# pylint: disable=invalid-name
 
 FilterType = Callable[[Union[List, np.ndarray], float, Optional[ListOrDict[float]]], bool]
 

qiskit/algorithms/eigensolvers/vqd.py

@@ -265,9 +265,7 @@ def compute_eigenvalues(
 
             # TODO: add gradient support after FidelityGradients are implemented
             if callable(self.optimizer):
-                opt_result = self.optimizer(  # pylint: disable=not-callable
-                    fun=energy_evaluation, x0=initial_point, bounds=bounds
-                )
+                opt_result = self.optimizer(fun=energy_evaluation, x0=initial_point, bounds=bounds)
             else:
                 # we always want to submit as many estimations per job as possible for minimal
                 # overhead on the hardware

qiskit/algorithms/gradients/finite_diff_estimator_gradient.py

@@ -31,7 +31,6 @@
 from ..exceptions import AlgorithmError
 
 if sys.version_info >= (3, 8):
-    # pylint: disable=no-name-in-module, ungrouped-imports
     from typing import Literal
 else:
     from typing_extensions import Literal

qiskit/algorithms/gradients/finite_diff_sampler_gradient.py

@@ -30,7 +30,7 @@
 from ..exceptions import AlgorithmError
 
 if sys.version_info >= (3, 8):
-    # pylint: disable=no-name-in-module, ungrouped-imports
+    # pylint: disable=ungrouped-imports
     from typing import Literal
 else:
     from typing_extensions import Literal

qiskit/algorithms/gradients/utils.py

@@ -10,8 +10,6 @@
 # copyright notice, and modified files need to carry a notice indicating
 # that they have been altered from the originals.
 
-# pylint: disable=invalid-name
-
 """
 Utility functions for gradients
 """

qiskit/algorithms/minimum_eigensolvers/sampling_vqe.py

@@ -210,7 +210,6 @@ def compute_minimum_eigenvalue(
         start_time = time()
 
         if callable(self.optimizer):
-            # pylint: disable=not-callable
             optimizer_result = self.optimizer(fun=evaluate_energy, x0=initial_point, bounds=bounds)
         else:
             # we always want to submit as many estimations per job as possible for minimal

qiskit/algorithms/optimizers/adam_amsgrad.py

@@ -201,7 +201,6 @@ def load_params(self, load_dir: str) -> None:
         },
         since="0.19.0",
     )
-    # pylint: disable=arguments-differ
     def minimize(
         self,
         fun: Callable[[POINT], float],

qiskit/algorithms/optimizers/optimizer.py

@@ -26,7 +26,7 @@
 from qiskit.algorithms.algorithm_result import AlgorithmResult
 
 if sys.version_info >= (3, 8):
-    # pylint: disable=no-name-in-module, ungrouped-imports
+    # pylint: disable=ungrouped-imports
     from typing import Protocol
 else:
     from typing_extensions import Protocol
@@ -41,7 +41,7 @@ class OptimizerResult(AlgorithmResult):
 
     def __init__(self) -> None:
         super().__init__()
-        self._x = None  # pylint: disable=invalid-name
+        self._x = None
         self._fun = None
         self._jac = None
         self._nfev = None

qiskit/algorithms/optimizers/scipy_optimizer.py

@@ -58,7 +58,6 @@ def __init__(
             kwargs: additional kwargs for scipy.optimize.minimize.
             max_evals_grouped: Max number of default gradient evaluations performed simultaneously.
         """
-        # pylint: disable=super-init-not-called
         self._method = method.lower() if isinstance(method, str) else method
         # Set support level
         if self._method in self._bounds_support_methods:

qiskit/algorithms/optimizers/steppable_optimizer.py

@@ -59,7 +59,7 @@ class OptimizerState:
 
     """
 
-    x: POINT  # pylint: disable=invalid-name
+    x: POINT
     """Current optimization parameters."""
     fun: Optional[Callable[[POINT], float]]
     """Function being  optimized."""

qiskit/algorithms/phase_estimators/phase_estimation.py

@@ -243,7 +243,6 @@ def estimate_from_pe_circuit(
             self._num_evaluation_qubits, circuit_result=circuit_result, phases=phases
         )
 
-    # pylint: disable=missing-param-doc
     def estimate(
         self,
         unitary: QuantumCircuit,

test/python/algorithms/minimum_eigensolvers/test_qaoa.py

@@ -33,8 +33,8 @@
 from qiskit.primitives import Sampler
 from qiskit.utils import algorithm_globals
 
-I = PauliSumOp.from_list([("I", 1)])  # pylint: disable=invalid-name
-X = PauliSumOp.from_list([("X", 1)])  # pylint: disable=invalid-name
+I = PauliSumOp.from_list([("I", 1)])
+X = PauliSumOp.from_list([("X", 1)])
 
 W1 = np.array([[0, 1, 0, 1], [1, 0, 1, 0], [0, 1, 0, 1], [1, 0, 1, 0]])
 P1 = 1

test/python/algorithms/minimum_eigensolvers/test_sampling_vqe.py

@@ -33,7 +33,7 @@
 from qiskit.utils import algorithm_globals
 
 
-# pylint: disable=invalid-name, unused-argument
+# pylint: disable=invalid-name
 def _mock_optimizer(fun, x0, jac=None, bounds=None, inputs=None):
     """A mock of a callable that can be used as minimizer in the VQE.
 

test/python/algorithms/optimizers/test_spsa.py

@@ -258,7 +258,6 @@ def objective(x):
 
     def test_point_sample(self):
         """Test point sample function in QNSPSA"""
-        # pylint: disable=invalid-name
 
         def fidelity(x, _y):
             x = np.asarray(x)

test/python/algorithms/test_grover.py

@@ -80,7 +80,6 @@ def is_good_state(bitstr):
         problem = AmplificationProblem(oracle, is_good_state=is_good_state)
 
         expected = [state in ["01", "11"] for state in possible_states]
-        # pylint: disable=not-callable
         actual = [problem.is_good_state(state) for state in possible_states]
 
         self.assertListEqual(expected, actual)