-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor state latex drawer #8874
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3940769746
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Ikko Hamamura <ikkoham@users.noreply.github.com>
…it-terra into latex-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my review comments. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded the release note a little, but otherwise this looks fine to me to merge. It's good to consolidate all the code in one place for consistency, and if it reduces some of the spaghetti back-and-forth we'd grown over time, I'm all for it. Thanks!
Summary
Currently, we have two different algorithms to display amplitudes as human-readable latex strings. This PR adapts the functions in qiskit/visualization/array.py so they work for both drawers, and deprecates the duplicate drawer.
Details and comments
precision
default in the matrix drawer needed increasing to continue recognising common amplitudes. The ket drawer should produce latex that renders identically so hopefully minimal disruption there.num_to_latex_ket
,numbers_to_latex_terms
) as they're quite specific to the drawer and I don't think it falls under Qiskit's scope to support them. I can't find any uses of them in the wild.This PR supersedes #8551