Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor state latex drawer #8551

Closed
wants to merge 36 commits into from

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Aug 16, 2022

Summary

This PR builds on #8273 and #8461.

In this PR I have:

1ucian0 and others added 30 commits June 29, 2022 15:08
Co-authored-by: Rishabh Chakrabarti <rishacha.dev@gmail.com>
…skit#8456)

* Fix is_real on ParameterExpression

* typo in reno

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Aug 16, 2022

Pull Request Test Coverage Report for Build 2874353207

  • 34 of 39 (87.18%) changed or added relevant lines in 2 files are covered.
  • 183 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.01%) to 84.036%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/array.py 27 29 93.1%
qiskit/visualization/state_visualization.py 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
qiskit/extensions/quantum_initializer/initializer.py 1 97.22%
qiskit/extensions/unitary.py 1 96.59%
qiskit/visualization/array.py 1 86.25%
qiskit/circuit/quantumcircuit.py 36 93.5%
qiskit/visualization/state_visualization.py 144 55.31%
Totals Coverage Status
Change from base Build 2862656180: -0.01%
Covered Lines: 56237
Relevant Lines: 66920

💛 - Coveralls

@mtreinish mtreinish added Changelog: Bugfix Include in the "Fixed" section of the changelog mod: visualization qiskit.visualization labels Aug 16, 2022
@mtreinish mtreinish added this to the 0.22 milestone Aug 16, 2022
@jakelishman
Copy link
Member

Is this intended to supersede/obsolete #8273 and #8461? If so, was it in discussion with @1ucian0 and @ryanhill1?

@frankharkins
Copy link
Member Author

Not my intention, I assumed those PRs are close to ready-to-merge, so it made more sense to build on them instead of re-solving the same problems in main. I didn't speak to either author, but I imagine they'd want to see the PR through, so probably best to review & merge those first before turning to this. I can fix any merge conflicts.

@frankharkins frankharkins marked this pull request as draft August 17, 2022 14:39
@rishacha
Copy link
Contributor

rishacha commented Aug 17, 2022

@1ucian0 - The fixes in this PR overlaps with some of the code in the 'noisy' PR #8174.

If this PR is allowed, then my original PR (linked above) shouldn't have been closed in the first place. It could've been linked to multiple issues, re-worded and reviewed with more fixes.

@mtreinish mtreinish removed this from the 0.22 milestone Sep 23, 2022
@frankharkins frankharkins deleted the fh-latex-refactor branch October 11, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: visualization qiskit.visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants