-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor state latex drawer #8551
Conversation
…ate-to-latex-ket/alternative1
…skit#8456) * Fix is_real on ParameterExpression * typo in reno Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…-latex-refactor
…-latex-refactor
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 2874353207
💛 - Coveralls |
Is this intended to supersede/obsolete #8273 and #8461? If so, was it in discussion with @1ucian0 and @ryanhill1? |
Not my intention, I assumed those PRs are close to ready-to-merge, so it made more sense to build on them instead of re-solving the same problems in main. I didn't speak to either author, but I imagine they'd want to see the PR through, so probably best to review & merge those first before turning to this. I can fix any merge conflicts. |
Summary
This PR builds on #8273 and #8461.
In this PR I have:
(
visualization.array._num_to_latex
andvisualization.state_visualization._num_to_latex_ket
)