Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Updating items on Infinite scroll now update observed data for ScrollSectionsMixin #1203

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Updating items on Infinite scroll now update observed data for ScrollSectionsMixin #1203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
450b9f2
fix update items not updating observed data
korgan00 Dec 3, 2020
0632fc5
update lastShown variable on items change and delay observed update o…
korgan00 Dec 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/ui/InfiniteScroll.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</template>

<script lang="ts">
import { Component, Mixins, Prop } from 'vue-property-decorator'
import { Component, Mixins, Prop, Watch } from 'vue-property-decorator'
import ScrollSectionsMixin from '~/mixins/scrollBetweenSections'

@Component
Expand All @@ -23,6 +23,12 @@ export default class extends Mixins(ScrollSectionsMixin) {

lastShown: number = Math.min(this.minItems, this.items.length)

@Watch('items')
onItemsChanged (newItems: Array<any>) : void {
this.lastShown = Math.min(this.minItems, newItems.length)
this.$nextTick(() => this.updateObserved())
}

/**
* This methods gets called when the active section changes.
* Inherited from ScrollSectionsMixin
Expand Down