-
Notifications
You must be signed in to change notification settings - Fork 108
Updating items on Infinite scroll now update observed data for ScrollSectionsMixin #1203
Updating items on Infinite scroll now update observed data for ScrollSectionsMixin #1203
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/qiskit/qiskitorg/7hcm1dsu7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @korgan00, but I’m afraid I could still see some issues when integrating this change to the advocates filter.
Current behaviour:
- Checking “Australia” and “Africa” displays 2 advocates.
Expected behaviour:
- Checking “Australia” and “Africa” should display 8 advocates (after some navigation).
Steps to reproduce:
- Check “Australia”
- Navigate to the “events” page
- Navigate to the “advocates” page
- Check also “Africa”
Additional information:
The Vuex store is calculating the 8 filtered advocates and passing these to the child component to render the cards properly.
Good catch! I made some other variables update. You can try it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @korgan00! 🙂
I just gave it a try integrating it with the new advocates filter and the issue that I reported before seems to be gone.
Nice work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
No description provided.