Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Updating items on Infinite scroll now update observed data for ScrollSectionsMixin #1203

Conversation

korgan00
Copy link
Contributor

@korgan00 korgan00 commented Dec 3, 2020

No description provided.

@vercel
Copy link

vercel bot commented Dec 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/qiskit/qiskitorg/7hcm1dsu7
✅ Preview: https://qiskitorg-git-fix-gi-i1182-infinite-scroll-bug.qiskit.now.sh

@vercel vercel bot temporarily deployed to Preview December 3, 2020 12:28 Inactive
Copy link
Collaborator

@eddybrando eddybrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @korgan00, but I’m afraid I could still see some issues when integrating this change to the advocates filter.

Current behaviour:

  • Checking “Australia” and “Africa” displays 2 advocates.

Expected behaviour:

  • Checking “Australia” and “Africa” should display 8 advocates (after some navigation).

Steps to reproduce:

  1. Check “Australia”
  2. Navigate to the “events” page
  3. Navigate to the “advocates” page
  4. Check also “Africa”

Additional information:

The Vuex store is calculating the 8 filtered advocates and passing these to the child component to render the cards properly.

@vercel vercel bot temporarily deployed to Preview December 3, 2020 18:39 Inactive
@korgan00
Copy link
Contributor Author

korgan00 commented Dec 3, 2020

Thanks for the update @korgan00, but I’m afraid I could still see some issues when integrating this change to the advocates filter.

Current behaviour:

  • Checking “Australia” and “Africa” displays 2 advocates.

Expected behaviour:

  • Checking “Australia” and “Africa” should display 8 advocates (after some navigation).

Steps to reproduce:

  1. Check “Australia”
  2. Navigate to the “events” page
  3. Navigate to the “advocates” page
  4. Check also “Africa”

Additional information:

The Vuex store is calculating the 8 filtered advocates and passing these to the child component to render the cards properly.

Good catch! I made some other variables update. You can try it again.

Copy link
Collaborator

@eddybrando eddybrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @korgan00! 🙂

I just gave it a try integrating it with the new advocates filter and the issue that I reported before seems to be gone.

Nice work 👍

Copy link
Contributor

@y4izus y4izus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@y4izus y4izus merged commit 34f9725 into Qiskit:feature/update-advocates-page Dec 4, 2020
@korgan00 korgan00 linked an issue Dec 9, 2020 that may be closed by this pull request
y4izus pushed a commit to y4izus/qiskit.org that referenced this pull request Dec 10, 2020
delapuente pushed a commit that referenced this pull request Dec 15, 2020
delapuente pushed a commit that referenced this pull request Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research possible bug of filters, possibly related to infinity scroll
3 participants