Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resources to gateway and scheduler containers #1357

Merged
merged 4 commits into from
Jun 7, 2024
Merged

add resources to gateway and scheduler containers #1357

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08b3258
add resources to gateway and scheduler containers
akihikokuroda Jun 6, 2024
622f278
add sleep after install
akihikokuroda Jun 6, 2024
bece550
add wait for gateway ready
akihikokuroda Jun 6, 2024
a79d79f
review comments
akihikokuroda Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/kubernetes-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ jobs:
--set gateway.application.ray.cpu=1 \
--set gateway.application.limits.keepClusterOnComplete=false \
.
sleep 120
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of a sleep, could we do a readiness check instead? something like :

kubectl wait --for=condition=Ready "$SOMEPOD" --timeout 5m

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better.

- name: setup python
uses: actions/setup-python@v4
with:
Expand Down
4 changes: 4 additions & 0 deletions charts/qiskit-serverless/charts/gateway/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ spec:
httpGet:
path: /readiness
port: http
initialDelaySeconds: 60
periodSeconds: 20
volumeMounts:
- mountPath: "/usr/src/app/media/"
name: gateway-pv-storage
Expand Down Expand Up @@ -253,6 +255,8 @@ spec:
name: gateway-pv-storage
- mountPath: "/tmp/templates/"
name: ray-cluster-template
resources:
{{- toYaml .Values.scheduler.resources | nindent 12 }}
env:
- name: DEBUG
value: {{ .Values.application.debug | quote }}
Expand Down
26 changes: 15 additions & 11 deletions charts/qiskit-serverless/charts/gateway/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,21 @@ ingress:
# hosts:
# - chart-example.local

resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
resources:
limits:
cpu: "1500m"
memory: "1Gi"
requests:
cpu: "500m"
memory: "700Mi"
scheduler:
resources:
limits:
cpu: "500m"
Tansito marked this conversation as resolved.
Show resolved Hide resolved
memory: "270Mi"
requests:
cpu: "100m"
memory: "180Mi"

autoscaling:
enabled: false
Expand Down
Loading