add resources to gateway and scheduler containers #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
psschwei
reviewed
Jun 6, 2024
| @@ -53,6 +53,7 @@ jobs: | |||
| --set gateway.application.ray.cpu=1 \ | |||
| --set gateway.application.limits.keepClusterOnComplete=false \ | |||
| . | |||
| sleep 120 | |||
There was a problem hiding this comment.
instead of a sleep, could we do a readiness check instead? something like :
kubectl wait --for=condition=Ready "$SOMEPOD" --timeout 5m
psschwei
approved these changes
Jun 6, 2024
Tansito
reviewed
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
resourcesin gateway and scheduler containers.The
cpulimitsfor gateway affects the startup time of the gateway pod. Thereadinessprobe configuration is changed to work with thecpulimitsvalue in this PR.Details and comments