Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#228 Implementation of equals/hashCode of CubeId is reworked #229

Conversation

alexeiakimov
Copy link
Contributor

Description

Fix for the #228.

Type of change

Internal implementation of CubeId is fixed, no changes in API or serialization format have been introduced

How Has This Been Tested? (Optional)

CubeIdTest is extended to include the scenarios what failed before the fix.

@alexeiakimov alexeiakimov self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #229 (b261b85) into main (f066acf) will decrease coverage by 0.07%.
The diff coverage is 94.73%.

❗ Current head b261b85 differs from pull request most recent head c1c144f. Consider uploading reports for the commit c1c144f to get more accurate results

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   92.00%   91.94%   -0.07%     
==========================================
  Files          88       88              
  Lines        2214     2209       -5     
  Branches      168      164       -4     
==========================================
- Hits         2037     2031       -6     
- Misses        177      178       +1     
Files Coverage Δ
...e/src/main/scala/io/qbeast/core/model/CubeId.scala 95.62% <94.73%> (-0.74%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@alexeiakimov
Copy link
Contributor Author

The PR closed, because of incorrect target branch. The fix is provided in the PR #231.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants