Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CubeId has incorrect implementation of equals and hashCode #228

Closed
alexeiakimov opened this issue Nov 7, 2023 · 0 comments
Closed

CubeId has incorrect implementation of equals and hashCode #228

alexeiakimov opened this issue Nov 7, 2023 · 0 comments
Assignees
@alexeiakimov
Labels
priority: high This issue has high priority status: in-progress This issue is in progress

Comments

@alexeiakimov
Copy link
Contributor

What went wrong?

io.qbeast.core.model.CubeId has incorrect implementation of equals/hashCode.

How to reproduce?

Different steps about how to reproduce the problem.

1. Code that triggered the bug, or steps to reproduce:

val id1 = CubeId(1, 1, Array(1L))
val id2 = CubeId(1, 1, Array(9L))
id1 == id2 shouldBe true
id1.hashCode() shouldBe id2.hashCode()

2. Branch and commit id:

The main branch at f066acf
@alexeiakimov alexeiakimov added the type: bug Something isn't working label Nov 7, 2023
@alexeiakimov alexeiakimov self-assigned this Nov 7, 2023
@alexeiakimov alexeiakimov added priority: high This issue has high priority type: bug status: in-progress This issue is in progress and removed type: bug Something isn't working labels Nov 7, 2023
alexeiakimov added a commit to alexeiakimov/qbeast-spark that referenced this issue Nov 9, 2023
@alexeiakimov
Qbeast-io#228 Implementation of equals/hashCode of CubeId is reworked
c1c144f
This was referenced Nov 9, 2023
Closed
Merged
alexeiakimov added a commit to alexeiakimov/qbeast-spark that referenced this issue Nov 15, 2023
@alexeiakimov
Qbeast-io#228 Test coverage of CubeId is improved.
882a7f1
cugni added a commit that referenced this issue Nov 23, 2023
@cugni
Merge pull request #231 from alexeiakimov/228-cubeid-has-incorrect-im…
cdcc4e2 
…plementation-of-equals-and-hashcode

#228 Implementation of equals/hashCode of CubeId is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexeiakimov alexeiakimov

Labels
priority: high This issue has high priority status: in-progress This issue is in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeiakimov