Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test regression caused by 8bbf915. #5085

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix test regression caused by 8bbf915. #5085

merged 1 commit into from
Jul 11, 2024

Conversation

ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jul 11, 2024 •
edited
Loading

Proposed changes

#4383 missed updating acforce tests

estimator-acforce-legacy-1-16
estimator-acforce-fast-1-16

What type(s) of changes does this code introduce?

  • Testing changes (e.g. new unit/integration/performance tests)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

bora

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'

@ye-luo
Copy link
Contributor Author

ye-luo commented Jul 11, 2024

Test this please.

prckent
prckent approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@prckent prckent merged commit d080ecc into QMCPACK:develop Jul 11, 2024
41 of 42 checks passed
@ye-luo ye-luo deleted the update-acforce-test branch July 11, 2024 13:42
@ye-luo ye-luo restored the update-acforce-test branch July 11, 2024 14:59
@ye-luo ye-luo deleted the update-acforce-test branch July 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ye-luo @prckent