Updated reference values and integration grid fix #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test this please |
|
Test this please |
|
Test this please |
markdewing
approved these changes
Jan 6, 2023
markdewing
changed the title
ye-luo
added a commit
to ye-luo/qmcpack
that referenced
this pull request
Jul 11, 2024
…cforce tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Putting this to get CI and see if everything passes without disrupting #4363 . Includes the two line fix from @markdewing to fix the integration grid randomization.
Updated reference values for all the deterministic tests affected by the non-local integration grid randomization fix.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
nitrogen, gcc old (11.3.0), openmpi, cpu and legacy cuda. real, complex, mixed, full.
Checklist