Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce InPhaseSpacePoint #68

Merged
merged 43 commits into from
May 27, 2024
Merged

Introduce InPhaseSpacePoint #68

merged 43 commits into from
May 27, 2024

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented May 22, 2024 •
edited
Loading

This PR adds a type InPhaseSpacePoint, which is a partially specialized version of a PhaseSpacePoint. It can be used to dispatch in places where only the incoming part of a phase space is required. Construction of PhaseSpacePoints now allows empty tuples for either incoming or outgoing phase spaces.

Left to do:

  • Specific Constructors for InPhaseSpacePoint
  • Review that doc strings are up to date
  • Add more (negative) tests for InPhaseSpacePoints

Uwe Hernandez Acosta and others added 28 commits May 16, 2024 15:53
updated tests for process interface
70ce920
updated docstrings describing the process interface
6baf36c
formatting
ae0f18e
opt out the evaluation of cross sections and probabilities on sets of…
f9705ae 
… inputs
formatting
24e49b2
updated diffCS and diffProb to PSPs, removed old interface, updated t…
69593f2 
…ests, rearranged files
updated perturbative Compton to PSPs
dff0d20
formatting
62c430d
cleanup tests for cross sections and probabilities; formatting
63c3ec6
@szabo137 @AntonReinhard
Apply suggestions from code review
7e78c2b 
Co-authored-by: Anton Reinhard <anton.reinhard@proton.me>
@AntonReinhard
Improve type info for PS
94a560c
@AntonReinhard
Move generate_phasespacepoint into constructor
f2b646c
@AntonReinhard
Improve performance with type magic
a00d35b
EOD
7a1fa95
@AntonReinhard
Improve type checking with even more type magic and fix (some) tests
1010dae
@AntonReinhard
Fix last type instability in psp construction from momenta
2cf05e6
@AntonReinhard
Rebase fix
11250f3
@AntonReinhard
Add (possibly temporary) fix for tests
6deedcc
@AntonReinhard
Fix doctests
3b479ab
@AntonReinhard
Remove unused functions
a3ed261
@AntonReinhard
Make pretty print tests prettier
aaab777
Tentative merge remote-tracking branch 'Uwe/update-diffCS-interface' …
c7692ee 
…into 58-ps-improve
@AntonReinhard
Merge remote-tracking branch 'QED/dev' into 58-ps-improve
6da8127
@AntonReinhard
Review changes
179fb0b
@AntonReinhard
Move phase_spaces.jl into directory and split into files
d267ced
@AntonReinhard
Add directional PhaseSpacePoint aliases and tests
3bf45dc
@AntonReinhard
Use Tuples everywhere instead of Tuples and introduce IncomingPhaseSp…
da6adf9 
…acePoints into interfaces
@AntonReinhard
Format
35a5be4
@AntonReinhard AntonReinhard requested a review from szabo137 May 22, 2024 14:26
@AntonReinhard AntonReinhard changed the title Introduce IncomingPhaseSpacePoint Introduce InPhaseSpacePoint May 22, 2024
@AntonReinhard AntonReinhard marked this pull request as ready for review May 23, 2024 12:19
@AntonReinhard
Copy link
Member Author

It might be good to have some more tests for the generation of PSPs and InPSPs from coordinates. They're currently only tested through usage in other higher-level tests like the Compton tests, but it might be good to have some unit tests for them as well. I'm not completely sure how the generate_momenta actually works though, so it might be better if @szabo137 can do this?

@AntonReinhard AntonReinhard mentioned this pull request May 24, 2024
Draft
6 tasks
szabo137
szabo137 reviewed May 24, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good for me, just some small comments.

Regarding the unit tests involving _generate_momenta, I will send in something later.

src/cross_section/diff_cross_section.jl Outdated Show resolved Hide resolved
src/cross_section/total_cross_section.jl Show resolved Hide resolved
src/cross_section/total_cross_section.jl Outdated Show resolved Hide resolved
src/cross_section/total_probability.jl Outdated Show resolved Hide resolved
src/interfaces/process_interface.jl Show resolved Hide resolved
src/phase_spaces/types.jl Outdated Show resolved Hide resolved
src/phase_spaces/types.jl Show resolved Hide resolved
src/phase_spaces/utility.jl Outdated Show resolved Hide resolved
test/interfaces/process_interface.jl Show resolved Hide resolved
test/test_implementation/groundtruths.jl Show resolved Hide resolved
@AntonReinhard
Copy link
Member Author

@szabo137 Please review again and check if your comments are resolved

@AntonReinhard AntonReinhard mentioned this pull request May 27, 2024
Merged
@szabo137 szabo137 mentioned this pull request May 27, 2024
Closed
AntonReinhard added a commit to QEDjl-project/QEDbase.jl that referenced this pull request May 27, 2024
@AntonReinhard
Export AbstractFourMomentum (#66)
a394e86 
As discussed here:
QEDjl-project/QEDprocesses.jl#68 (comment)
szabo137
szabo137 approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! All comments are addressed and the issues are solved. Thank you very much for the contribution, nice work!

Edit: my bad, there was one little comment which slipped through. However, feel free to resolve it by yourself and merge.

@AntonReinhard AntonReinhard merged commit c768a57 into QEDjl-project:dev May 27, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the 65_psp_alias branch May 27, 2024 20:21
This was referenced Jun 13, 2024
Closed
Closed
Closed
@szabo137 szabo137 added this to the Release-next milestone Jul 15, 2024
@szabo137 szabo137 added 05 - Enhancement Improvements of existing code 06 - Feature-request Missing a feature or functionality labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
05 - Enhancement Improvements of existing code 06 - Feature-request Missing a feature or functionality
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonReinhard @szabo137