Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement of phase space point #58

Closed
6 tasks done
szabo137 opened this issue May 16, 2024 · 1 comment
Closed
6 tasks done

Enhancement of phase space point #58

szabo137 opened this issue May 16, 2024 · 1 comment
Assignees
@AntonReinhard
Labels
05 - Enhancement Improvements of existing code

Comments

@szabo137
Copy link
Member

szabo137 commented May 16, 2024 •
edited by AntonReinhard
Loading

The current implementation of ParticleStateful and PhaseSpacePoint could be improved. Here we collect some ideas:

particle stateful

  • expose the types of the fields as type-parameters
  • remove spin information from particle stateful (will be added to the process interface)

phase space point

  • Think about saving only the momenta and wrapping the particle stateful type only on access,
  • make generate_phase_space private and all it in a constructor of PhaseSpacePoint,
  • add construction of phase space points from coordinates, maybe using the functions _generate_incoming_momenta and _generate_outgoing_momenta from the process interface.
  • add abbreviations for momentum.(psp.in_particles) and momentum.(psp.out_particles
@szabo137 szabo137 added the 05 - Enhancement Improvements of existing code label May 16, 2024
@AntonReinhard AntonReinhard mentioned this issue May 19, 2024
Merged
szabo137 added a commit that referenced this issue May 22, 2024
@AntonReinhard @szabo137
Proposal for PhaseSpacePoint improvement (#63)
80dbcc2 
Proposal for a rework of the PhaseSpacePoint, according to Issue #58

I did a lot of type magic with recursive variadic templates to find out
type information and get functions perfectly type stable. Constructing
phase space points is now always type stable and takes a maximum of
~11ns for me when constructing from momenta.

Some of the tests are failing for now because some of the interfaces
currently don't expect tuples from the PSP implementation. It might make
sense to fix this in #59

---------

Co-authored-by: Uwe Hernandez Acosta <u.hernandez@hzdr.de>
Co-authored-by: Uwe Hernandez Acosta <szabo137@users.noreply.github.com>
Co-authored-by: AntonReinhard <anton.reinhard@protonmail.com>
@AntonReinhard
Copy link
Member

Fully solved with #63 and #68

@szabo137 szabo137 mentioned this issue Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonReinhard AntonReinhard

Labels
05 - Enhancement Improvements of existing code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szabo137 @AntonReinhard