Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PhasespaceDefinition in favor of PhaseSpaceLayout #94

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Jan 27, 2025

Fix for QEDjl-project/QEDbase.jl#150

Summary

  • removed PhasespaceDefinition
  • updated PhaseSpacePoint and related subtypes
  • updated tests respectively

TODO

  • Update pretty printing
  • Update docs

Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/phase_spaces/types.jl Outdated Show resolved Hide resolved
src/phase_spaces/types.jl Outdated Show resolved Hide resolved
test/phase_spaces.jl Outdated Show resolved Hide resolved
test/phase_spaces.jl Outdated Show resolved Hide resolved
@AntonReinhard
Copy link
Member

At some point we need a concrete PhaseSpaceLayout, should this be defined in this PR? Or in QEDprocesses?

@szabo137 szabo137 force-pushed the remove_psdef_update_psp branch from 642670f to e158331 Compare February 6, 2025 07:04
@szabo137
Copy link
Member Author

szabo137 commented Feb 6, 2025

@SimeonEhrig Could you please come to rescue: How do I change the depency on QEDbase for the docs building? The CI for doc building should use https://github.com/AntonReinhard/QEDbase.jl#remove-psdef but used the dev-branch of QEDbase instead.

@SimeonEhrig
Copy link
Member

@SimeonEhrig Could you please come to rescue: How do I change the depency on QEDbase for the docs building? The CI for doc building should use https://github.com/AntonReinhard/QEDbase.jl#remove-psdef but used the dev-branch of QEDbase instead.

No supported for GitHub Actions 😅
The function is prepared for it: https://github.com/QEDjl-project/QuantumElectrodynamics.jl/blob/9cb97f84047a2740786a072a9184fbca6e3dbb82/.ci/CI/src/modules/Utils.jl#L297C10-L297C44
I simply does not check, if I'm on GitHub Actions or GitLab CI. It assumes GItLab CI all the time. Therefore the commit message is not set on GitHub Actions and I cannot extract custom URLs. I will implement the feature.

@SimeonEhrig SimeonEhrig force-pushed the remove_psdef_update_psp branch 2 times, most recently from 22f6e5e to e158331 Compare February 6, 2025 13:28
@SimeonEhrig
Copy link
Member

@szabo137 Supporting custom URLs in GitHub Actions requires more work than expected. I need to clean up and refactor some parts of CI library because GitHub Actions has a strange behavior if you set environment variables:
https://stackoverflow.com/questions/74353311/github-workflow-unable-to-process-file-command-env-successfully

I will do it after my vacations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants