-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PhasespaceDefinition in favor of PhaseSpaceLayout #94
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
At some point we need a concrete |
Co-authored-by: Anton Reinhard <anton.reinhard@proton.me>
CI_UNIT_PKG_URL_QEDbase: https://github.com/AntonReinhard/QEDbase.jl#066fefd75ed1af1cc9c69ff3a13944d514c9e490
642670f
to
e158331
Compare
@SimeonEhrig Could you please come to rescue: How do I change the depency on QEDbase for the docs building? The CI for doc building should use https://github.com/AntonReinhard/QEDbase.jl#remove-psdef but used the dev-branch of QEDbase instead. |
No supported for GitHub Actions 😅 |
22f6e5e
to
e158331
Compare
@szabo137 Supporting custom URLs in GitHub Actions requires more work than expected. I need to clean up and refactor some parts of CI library because GitHub Actions has a strange behavior if you set environment variables: I will do it after my vacations. |
Fix for QEDjl-project/QEDbase.jl#150
Summary
PhasespaceDefinition
PhaseSpacePoint
and related subtypesTODO