Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] add some shows #155

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[patch] add some shows #155

merged 2 commits into from
Feb 3, 2025

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Feb 3, 2025 •
edited
Loading

adds:

  • generic Base.show for AbstractParticleTypes
  • Base.show for some mocks

This should be merged before: #150 and QEDjl-project/QEDcore.jl#94

@szabo137 szabo137 changed the title Add some shows [patch] add some shows Feb 3, 2025
AntonReinhard
AntonReinhard previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question

src/utils.jl Outdated Show resolved Hide resolved
@szabo137 szabo137 merged commit 658255f into QEDjl-project:dev Feb 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonReinhard AntonReinhard AntonReinhard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szabo137 @AntonReinhard