Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Build POT against oldest-supported-numpy #347

Closed
wants to merge 5 commits into from
Closed

[WIP] Build POT against oldest-supported-numpy #347

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3740b48
Configure setup to compile against oldest supported numpy version usi…
davidghiurco Feb 11, 2022
aa1a495
Set minimum Python requirement to `>=3.7` in setup.py since !328 remo…
davidghiurco Feb 11, 2022
77a2b7f
Fix typo in pyproject.toml - build all wheels
davidghiurco Feb 11, 2022
04b1cf9
Update setup.py build all wheels
rflamary Feb 11, 2022
2cf13dd
Update setup.py and build wheels
rflamary Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -U "cython"

- name: Install cibuildwheel
run: |
Expand All @@ -37,7 +36,6 @@ jobs:
- name: Build wheels
env:
CIBW_SKIP: "pp*-win* pp*-macosx* cp2* pp* cp36*" # remove pypy on mac and win (wrong version)
CIBW_BEFORE_BUILD: "pip install numpy cython"
run: |
python -m cibuildwheel --output-dir wheelhouse

Expand Down Expand Up @@ -81,7 +79,6 @@ jobs:
- name: Build wheels
env:
CIBW_SKIP: "pp*-win* pp*-macosx* cp2* pp* cp*musl* cp36*" # remove pypy on mac and win (wrong version)
CIBW_BEFORE_BUILD: "pip install numpy cython"
CIBW_ARCHS_LINUX: auto aarch64 # force aarch64 with QEMU
CIBW_ARCHS_MACOS: x86_64 universal2 arm64
run: |
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
requires = ["setuptools", "wheel", "numpy>=1.20", "cython>=0.23"]
requires = ["setuptools", "wheel", "oldest-supported-numpy", "cython>=0.23"]
build-backend = "setuptools.build_meta"
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
numpy>=1.20
scipy>=1.3
cython
matplotlib
autograd
pymanopt==0.2.4; python_version <'3'
Expand Down
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@
license='MIT',
scripts=[],
data_files=[],
setup_requires=["numpy>=1.20", "cython>=0.23"],
install_requires=["numpy>=1.20", "scipy>=1.0"],
setup_requires=["oldest-supported-numpy", "cython>=0.23"],
install_requires=["numpy>=1.16", "scipy>=1.0"],
python_requires=">=3.7",
rflamary marked this conversation as resolved.
Show resolved Hide resolved
classifiers=[
'Development Status :: 5 - Production/Stable',
'Intended Audience :: Developers',
Expand All @@ -91,7 +92,6 @@
'Topic :: Scientific/Engineering :: Mathematics',
'Topic :: Scientific/Engineering :: Information Analysis',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
Expand Down