-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Build POT against oldest-supported-numpy #347
[WIP] Build POT against oldest-supported-numpy #347
Conversation
…ng the meta-package: https://pypi.org/project/oldest-supported-numpy/ - build all wheels
…ved Python 3.6 support - build all wheels
@rflamary Given these changes, we might be able to roll-back the The reason I introduced the minimum Python version / But it looks like it might have been dropped pre-maturely due to the nature of the |
If you change That is if you want to re-add Python 3.6 support. |
Hello @davidghiurco and thank you for the PR. I'm not sure why but the github actions for building the wheels are not triggered so I will probably ope a new PR wfrom this one on a branc of POT to ensure that the wheels are building OK before merging |
@rflamary is there a difference between |
well build all wheels is longer because it build on ARM for linux but both should run, i really believe i need to have the pr on a branch of POT to make it work (but i don't see why it does not run in PR only from the github action conditions...) |
I'm closing this PR since #349 have now been merged, thanks again @davidghiurco we will have a smooth release next time ;) |
Types of changes
Build / setup:
numpy
version possible given the platform, while also still allowingnumpy>=1.20
to be used** NOTE: I suspect POT would happily support & compile against even older
numpy
versions, and maintain forward compatibility with newernumpy
, but I'm not sure.pyproject.toml
in [WIP] POT build without installing cython first #293python_requires
to>=3.7
. Python 3.6 support was dropped in POT release0.8.1
. This configuration is also necessary to helpoldest-supported-numpy
properly determine what the oldest version ofnumpy
it should use during setup.Motivation and context / Related issue
Address #346
How has this been tested (if it applies)
PR checklist