-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option Redesign (fix for #513) #863
Conversation
Head branch was pushed to by a user without write access
@emretech what's the current state of this |
I've tested it, and it should be done now. I'm just waiting for reviews. |
This seems to break if parentheses are in the option description. @client.slash_command()
async def dis_is_test(ctx, channel: discord.Option(discord.TextChannel, description="Is a channel? (yes)")):
await ctx.respond(channel.mention) Value that is passed into |
Working on it, thanks for telling me |
Done. |
Holy fuck, this got big. |
Closing in favor of #1251. |
I'll do some code fixes and try to improve this PR |
We reviewed this pr internally and its too messy rn and wasnt in progress for a week / longer. Sorry, but this is the end decision for now. |
2 months is just too long |
Summary
This PR fixes #513 by redesigning how Options are set. This also documents the Option class.
TODO List for this PR to be merged:
option
decorator to reflect how Options are set nowChecklist
type: ignore
comments were used, a comment is also left explaining why