Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for AutocompleteContext, Option, OptionChoice, and on_application_command* events. #1103

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

krittick
Copy link
Contributor

@krittick krittick commented Mar 2, 2022

Summary

This adds docstrings and doc tables for the following:

  • Option
  • OptionChoice
  • AutocompleteContext
  • Bot.on_application_command()
  • Bot.on_application_command_completion()
  • Bot.on_application_command_error()
  • utils.basic_autocomplete()

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added documentation Improvements or additions to documentation priority: high High Priority status: awaiting review Awaiting review from a maintainer bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. Merge with squash labels Mar 2, 2022
@krittick krittick added this to the v2.0 milestone Mar 2, 2022
@krittick krittick self-assigned this Mar 2, 2022
@EmmmaTech
Copy link
Contributor

Should I remove the Option docs from #863?

@krittick
Copy link
Contributor Author

krittick commented Mar 2, 2022

Should I remove the Option docs from #863?

I was just about to comment there. I'd update them to match once this gets merged, keeping any major changes from your PR.

@krittick krittick enabled auto-merge (squash) March 2, 2022 23:27
@krittick krittick merged commit f4b0d07 into Pycord-Development:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass-review Bypasses reviews for urgent pull requests involving critical code or documentation fixes. documentation Improvements or additions to documentation priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants