feat: add new parameters to discord.Embed

[davidhozic]

Summary

This PR adds parameters to discord.Embed as proposed in #1995.
It also adds 2 new classes to support the latter. The classes are: EmbedFooter and EmbedAuthor

Example:

import discord
import secret


embed = discord.Embed(
    author=discord.EmbedAuthor(
        name="Mr. President",
        icon_url="https://media.discordapp.net/attachments/1044657935608987808/1065995582654664724/svetlogo.png"
    ),
    footer=discord.EmbedFooter(text="This is a footer")
)


client = discord.Client()


@client.listen("on_ready")
async def start():
    channel = client.get_channel(1091835594243592293)
    await channel.send(embed=embed)
    await client.close()


client.run(secret.TOKEN)

which produces

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[codecov]

Codecov Report

Merging #1996 (9dc4548) into master (8fb956c) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
- Coverage   33.33%   33.32%   -0.01%     
==========================================
  Files          97       97              
  Lines       18900    18916      +16     
==========================================
+ Hits         6300     6304       +4     
- Misses      12600    12612      +12     

Flag	Coverage Δ
macos-latest-3.10	33.31% <28.57%> (-0.01%)	⬇️
macos-latest-3.11	33.31% <28.57%> (-0.01%)	⬇️
macos-latest-3.8	33.32% <28.57%> (-0.01%)	⬇️
macos-latest-3.9	33.32% <28.57%> (-0.01%)	⬇️
ubuntu-latest-3.10	33.31% <28.57%> (-0.01%)	⬇️
ubuntu-latest-3.11	33.31% <28.57%> (-0.01%)	⬇️
ubuntu-latest-3.8	33.32% <28.57%> (-0.01%)	⬇️
ubuntu-latest-3.9	33.32% <28.57%> (-0.01%)	⬇️
windows-latest-3.10	33.31% <28.57%> (-0.01%)	⬇️
windows-latest-3.11	33.31% <28.57%> (-0.01%)	⬇️
windows-latest-3.8	33.32% <28.57%> (-0.01%)	⬇️
windows-latest-3.9	33.32% <28.57%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
discord/embeds.py	25.00% <28.57%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb956c...9dc4548. Read the comment docs.

[JustaSqu1d]

Also, note the change in their respective properties.

[JustaSqu1d]

Should we deprecate set_author, etc?

[davidhozic]

Should we deprecate set_author, etc?

I think that's a good idea yes

[davidhozic]

Should we deprecate set_author, etc?

I think that's a good idea yes

On second thought, I'd leave it in, you still have the set_field_at and remove_field and other remove_ methods available.
Maybe you for example want to modify an embed from a received message and send it back, so these methods can be helpful.

[Lulalaby]

Should we deprecate set_author, etc?

No, not in every case you want to use the constructor.
And what if you want to modify it afterwards

[Nzii3]

I mean, I don't really see the point in this but, idk.

[plun1331]

Ideally, embed.footer and embed.author should return their respective classes

[davidhozic]

Not sure what proxy_icon_url is supposed to be, but I'll leave it in the constructor since it's needed for the @properties and it will give you an error anyways if you try to provide it manually since Embed internally calls the set_ methods in it's constructor.

[plun1331]

Not sure what proxy_icon_url is supposed to be, but I'll leave it in the constructor since it's needed for the @properties and it will give you an error anyways if you try to provide it manually since Embed internally calls the set_ methods in it's constructor.

it's a value returned by discord that proxies the image through their cdn iirc

[Lulalaby]

it's a value returned by discord that proxies the image through their cdn iirc

That's correct