Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed class missing property setters #2197

Closed
Lulalaby opened this issue Aug 6, 2023 · 4 comments · Fixed by #2198
Closed

Embed class missing property setters #2197

Lulalaby opened this issue Aug 6, 2023 · 4 comments · Fixed by #2198
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed on hold priority: medium Medium Priority
Milestone
v2.5

Comments

@Lulalaby
Copy link
Member

Lulalaby commented Aug 6, 2023 •
edited
Loading

Some setters weren't added but parameters introduced.

From @TheGiga
image
@Lulalaby Lulalaby added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority: medium Medium Priority on hold labels Aug 6, 2023
@Lulalaby Lulalaby added this to the v2.5 milestone Aug 6, 2023
@Lulalaby Lulalaby changed the title Embed class missing setters Embed class missing property setters Aug 6, 2023
@FloncDev
Copy link

FloncDev commented Aug 6, 2023

Shouldn't you use Embed.set_thumbnail() instead of Embed.thumbnail = ... to set the thumbnail?

@OmLanke
Copy link
Contributor

OmLanke commented Aug 6, 2023

Embed.thumbnail = ... will allow you to use an instance of discord.EmbedMedia
Embed.set_thumbnail() allows you to pass the data as parameters

@FloncDev
Copy link

FloncDev commented Aug 6, 2023

To my knowledge, the other 3 parameters of EmbedMedia are generated by discord so editing them will have no effect.

@OmLanke
Copy link
Contributor

OmLanke commented Aug 6, 2023

Yes but there is also EmbedAuthor and EmbedFooter. This issue is for all of them

@OmLanke OmLanke mentioned this issue Aug 6, 2023
Merged
9 tasks
@FloncDev FloncDev mentioned this issue Aug 6, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed on hold priority: medium Medium Priority
Projects
Pycord Releases
Status: Done
Milestone
v2.5
3 participants
@Lulalaby @FloncDev @OmLanke