solar pv tracking option added #255

enrilizaga · 2022-09-14T17:34:40Z

Change proposed in this Pull Request

Added 1-axis vertical and 2-axis tracking option for solar pv (+ small documentation addition for get_windturbineconfig)

Description

Updated orientation.py and convert.py:

Default option is no tracking (tracking = 0)
For vertical tracking, surface azimuth = sun_azimuth angles
For 2-axis tracking, both the azimuth and the slope follow the sun, thus cos(incidence angle)=1

Motivation and Context

This change adds the solar pv tracking capability to the code. Solar pv tracking is widely used as it increases the solar pv efficiency significantly. This change improves the fidelity of the code to represent those efficiencies

How Has This Been Tested?

The updated code was tested locally (see snapshots)

The following commands provided the same results (tracking = 0 default)
cap_factors_pv_notrack = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, capacity_factor=True)
cap_factors_pv_0axis = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, tracking=0, capacity_factor=True)
Tracking = 1 and =2 were tested as well:
cap_factors_pv_1axis = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, tracking=1, capacity_factor=True)
cap_factors_pv_2axis = cutout.pv(panel='CSi', orientation={'slope': 30., 'azimuth': 180.}, tracking=2, capacity_factor=True)
Checked that csp was not affected (tracking change only for solar pv)
cf = cutout.csp(installation="SAM_solar_tower", capacity_factor=True)
cf = cutout.csp(installation="SAM_parabolic_trough", capacity_factor=True)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

I tested my contribution locally and it seems to work fine.
I locally ran pytest inside the repository and no unexpected problems came up.
I have adjusted the docstrings in the code appropriately.
I have documented the effects of my code changes in the documentation doc/.
I have added newly introduced dependencies to environment.yaml file.
I have added a note to release notes doc/release_notes.rst.
I have used pre-commit run --all to lint/format/check my contribution

… 2-axis tracking

for more information, see https://pre-commit.ci

FabianHofmann · 2022-10-11T06:58:04Z

Hey @enrilizaga, sorry this takes a while on our side... but the code looks great! Some optional point would be awesome

Could you add your notebook to the examples list? Then, we can also try it out, see the docs on how to add it
A note in the release notes (RELEASE_NOTES.rst) - just follow the pattern you see there.
A test would be nice in tests/test_preparation_and_conversion.py, have a look at https://github.com/PyPSA/atlite/pull/220/files

Would that be possible for you?

…ding .nblink - added pv_tracking_test function within test_preparation_and_conversion.py - added tracking option for trigon_model "simple" within tiltedirradiation function

for more information, see https://pre-commit.ci

enrilizaga · 2022-10-26T17:33:57Z

Hi @FabianHofmann, many thanks for your reply! I have:

added notebook example solarpv_tracking_options.ipynb and corresponding .nblink
added pv_tracking_test function within test_preparation_and_conversion.py
added tracking option for trigon_model "simple" within tiltedirradiation function
added new version 0.2.10 in the RELEASE_NOTES.rst

Please let me know.
Thank you!

FabianHofmann · 2022-10-28T13:39:59Z

This is awesome. I'm having a look at the changes next week.

fneum · 2022-11-13T09:14:26Z

Ping! Would be super cool to include it in the upcoming PyPSA-Eur version.

fneum · 2022-11-13T09:15:19Z

closes #140
closes #220

FabianHofmann

@enrilizaga the code look great! Some comments from my side. I am currently running the notebook. I also want to make a check that the pv for tracking=0 is the same as in the current master.

FabianHofmann · 2022-11-17T10:17:50Z

atlite/convert.py

+        as accepted by atlite.resource.get_windturbineconfig(). Locally stored turbine
+        configurations can also be modified with this function. E.g. to setup a different hub
+        height from the one used in the yaml file,one would write
+                "turbine=get_windturbineconfig(“NREL_ReferenceTurbine_5MW_offshore”)|{“hub_height”:120}"


I am wondering where this change is coming from.

Good change!

@FabianHofmann just a small doc addition explaining how to modify the wind hub height. This is unrelated to the pv tracking update

FabianHofmann · 2022-11-17T10:20:57Z

atlite/convert.py

@@ -530,21 +532,24 @@ def wind(cutout, turbine, smooth=False, **params):


 # solar PV
-def convert_pv(ds, panel, orientation, trigon_model="simple", clearsky_model="simple"):
+def convert_pv(
+    ds, panel, orientation, tracking, trigon_model="simple", clearsky_model="simple"


Can we make tracking a keyword argument here?

Default to no tracking would be a sensible choice.

Just updated it. The no tracking option is the default option (e.g. see third assertion of pv_tracking_test)

FabianHofmann · 2022-11-17T10:27:58Z

atlite/convert.py

+    tracking : int 0, 1, 2:
+        0 for no tracking, default
+        1 for 1-axis vertical tracking
+        2 for 2-axis tracking


I am wondering whether we should rather take the arguments

False,

'v' or 'vertical'

'h' or 'horizontal'

'full'

where horizontal is not supported right now. This would make integration in the future easier. Could you change this?

or instead of "full" -> "hv" or "vh"

good idea indeed! I have not included 'horizontal' as that is not supported by the code, but should be now easier to integrate it in the future

Sorry to jump in here without actually reviewing the code but this comment caught my attention. I think we should prioritize including 1-axis horizontal tracking.
In short, horizontal 1-axis tracking is widely used in the market today (about 50% of new PV power plants use it) while 2-axis or vertical tracking is not used at all.
I understand that this PR only includes vertical and 2-axes (and that is great, thanks for the work @enrilizaga ) but I think it would look weird in the next release if only exotic options are included but not the dominant "horizontal 1-axis tracking".

Thanks @martavp. I understand your point, but I am not sure why that would prevent this PR from being added into the code? Horizontal 1-axis tracking may be more widely used, but it is also more complex to implement and outside my scope of work. PS: would be great if you could share the reference re PV panels market share by tracking type!

@enrilizaga no worries, the PR is great (!) and this missing feature would not prevent it from being merged. But since you already have experience with the math, would you mind trying to lift the implementation to the full features stack? That would make it perfect. I had a try with horizontal tracking in #220 but due to missing time, I did not dig down any further. There you also find a reference (https://www.nrel.gov/docs/fy13osti/58891.pdf) for the hsat.

Thanks @martavp. I understand your point, but I am not sure why that would prevent this PR from being added into the code? Horizontal 1-axis tracking may be more widely used, but it is also more complex to implement and outside my scope of work. PS: would be great if you could share the reference re PV panels market share by tracking type!

I fully agree with @FabianHofmann, the PR is great and should be merged. I was just calling attention to the fact that we should try to add 1-axis horizontal tracking soon (ideally before the next release). I also did not find the time to work on this myself, so thanks again @enrilizaga for your contribution.

A good reference for the share of market representative of every tracking strategy can be the International Technology Roadmap for PV (ITRPV). You need to register to download the report and I cannot find the relevant figure in the most updated version, but check slide 35 from this presentation

Got it, thanks for the clarification. When is next release? I could look into it at some point in the next month or so but I am currently time constrained.

Re the market share, thanks for sharing that reference. Unfortunately ITRPV does not seem to have data on horizontal vs vertical 1-axis tracking separately and just reports all as "1-axis tracking"?

No pressure on the release date. If you can make it this year, that would be great. Otherwise I could also spend some hours, likely not before January on this. To give you a proper hint on the implementation I'd have make some research, which is atm not possible for me...

Hi @enrilizaga I'm pretty sure that ITRPV only mentions "1-axis tracking" assuming that is horizontal tracking. Vertical tracking is not used at all in commercial utility-scale applications.

I'm also time constrained until January, but I can also find some time there to make suggestions. I have also talked to @Parisra and she might be able to put some time into implementing this.

for more information, see https://pre-commit.ci

enrilizaga · 2022-11-28T14:25:41Z

@FabianHofmann @fneum thanks for your comments. Just included them in the last commit. Please let me know!

FabianHofmann · 2023-01-31T10:07:04Z

Hey @enrilizaga, do you have concrete plans on continuing on this PR? Otherwise, we could look whether we can find someone to finish it up.

martavp · 2023-02-02T13:48:30Z

I know that @Parisra is working on implementing the horizontal tracking option.
Mainly obtaining the tilt and orientation of the solar panels using Eq. 8-10 from NREL report
Maybe @FabianHofmann you can accept @enrilizaga PR and @Parisra takes it from there

fneum · 2023-02-02T13:54:29Z

I think that’d make sense. No need for full tracking implemented until merging.

FabianHofmann · 2023-02-03T09:06:00Z

@martavp let's do it :) @Parisra could you then make sure to counter test the formulas? I haven't had the time to go into them in detail.

@enrilizaga many thanks again! This is a great contribution and super well done!

Parisra · 2023-02-03T11:55:44Z

Hi @FabianHofmann , yes I can do that. I've just finished adding the formulas for horizontal tracking and will be doing some tests next week to make sure the results make sense. I'll do a pull request once everything is ready.

FabianHofmann · 2023-02-03T12:21:28Z

great thanks @Parisra

enrilizaga and others added 2 commits September 14, 2022 12:10

solar pv tracking option added. 0 no tracking, 1 vertical tracking, 2…

2d1fb3f

… 2-axis tracking

[pre-commit.ci] auto fixes from pre-commit.com hooks

20dd8c4

for more information, see https://pre-commit.ci

enrilizaga changed the title ~~solar pv tracking option added. 0 no tracking, 1 vertical tracking, 2…~~ solar pv tracking option added Sep 14, 2022

enrilizaga and others added 4 commits September 15, 2022 10:38

small documentation addition for get_windturbineconfig

1e9c47b

Merge remote-tracking branch 'origin/master'

dcb8414

minor formatting

4b8a6c7

[pre-commit.ci] auto fixes from pre-commit.com hooks

e79de50

for more information, see https://pre-commit.ci

euronion added type: enhancement status: in progress priority: medium status: help wanted labels Sep 19, 2022

FabianHofmann self-requested a review September 19, 2022 08:46

enrilizaga and others added 9 commits October 17, 2022 12:15

added new version

d055959

Merge remote-tracking branch 'origin/master'

7023208

new version description update

486108c

- added notebook example solarpv_tracking_options.ipynb and correspon…

f56d234

…ding .nblink - added pv_tracking_test function within test_preparation_and_conversion.py - added tracking option for trigon_model "simple" within tiltedirradiation function

Merge branch 'master' into master

b9617c1

[pre-commit.ci] auto fixes from pre-commit.com hooks

f799443

for more information, see https://pre-commit.ci

- notebook example

0259835

- small edit

1c0b6e6

- small edit

024ee9f

FabianHofmann requested changes Nov 17, 2022

View reviewed changes

enrilizaga and others added 3 commits November 28, 2022 09:00

- update "tracking" parameter to take keywords instead of integers

cb6228f

Merge branch 'PyPSA:master' into master

de4275c

[pre-commit.ci] auto fixes from pre-commit.com hooks

6c441ee

for more information, see https://pre-commit.ci

Merge branch 'master' into master

a4eeffa

FabianHofmann approved these changes Feb 3, 2023

View reviewed changes

FabianHofmann merged commit 2493c4b into PyPSA:master Feb 3, 2023

martavp mentioned this pull request Mar 16, 2023

PV horizontal tracking #280

Merged

10 tasks

fneum mentioned this pull request May 2, 2023

[Reviewed] PV horizontal tracking #293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solar pv tracking option added #255

solar pv tracking option added #255

enrilizaga commented Sep 14, 2022 •

edited

Loading

FabianHofmann commented Oct 11, 2022 •

edited

Loading

enrilizaga commented Oct 26, 2022

FabianHofmann commented Oct 28, 2022

fneum commented Nov 13, 2022

fneum commented Nov 13, 2022

FabianHofmann left a comment

FabianHofmann Nov 17, 2022

fneum Nov 17, 2022

enrilizaga Nov 28, 2022

FabianHofmann Nov 17, 2022

fneum Nov 17, 2022

enrilizaga Nov 28, 2022

FabianHofmann Nov 17, 2022

fneum Nov 17, 2022 •

edited

Loading

enrilizaga Nov 28, 2022

martavp Nov 28, 2022 •

edited

Loading

enrilizaga Nov 28, 2022

FabianHofmann Nov 29, 2022 •

edited

Loading

martavp Nov 29, 2022

enrilizaga Nov 29, 2022

FabianHofmann Nov 30, 2022

martavp Dec 4, 2022

enrilizaga commented Nov 28, 2022

FabianHofmann commented Jan 31, 2023

martavp commented Feb 2, 2023

fneum commented Feb 2, 2023

FabianHofmann commented Feb 3, 2023

Parisra commented Feb 3, 2023

FabianHofmann commented Feb 3, 2023

solar pv tracking option added #255

solar pv tracking option added #255

Conversation

enrilizaga commented Sep 14, 2022 • edited Loading

Change proposed in this Pull Request

Description

Motivation and Context

How Has This Been Tested?

Type of change

Checklist

FabianHofmann commented Oct 11, 2022 • edited Loading

enrilizaga commented Oct 26, 2022

FabianHofmann commented Oct 28, 2022

fneum commented Nov 13, 2022

fneum commented Nov 13, 2022

FabianHofmann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fneum Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martavp Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FabianHofmann Nov 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enrilizaga commented Nov 28, 2022

FabianHofmann commented Jan 31, 2023

martavp commented Feb 2, 2023

fneum commented Feb 2, 2023

FabianHofmann commented Feb 3, 2023

Parisra commented Feb 3, 2023

FabianHofmann commented Feb 3, 2023

enrilizaga commented Sep 14, 2022 •

edited

Loading

FabianHofmann commented Oct 11, 2022 •

edited

Loading

fneum Nov 17, 2022 •

edited

Loading

martavp Nov 28, 2022 •

edited

Loading

FabianHofmann Nov 29, 2022 •

edited

Loading