Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bottom panel when in fullscreen mode #1235

Closed
wants to merge 3 commits into from

Conversation

jbaiter
Copy link
Collaborator

@jbaiter jbaiter commented Jan 16, 2017

For some reason the bottom panel is disabled when Mirador is in fullscreen mode, making navigation pretty tedious. This PR removes the calls to disable the bottom panel in fullscreen mode.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 61.618% when pulling 9a01021 on dbmdz:bottompanel-in-fullscreen into b4248b4 on ProjectMirador:2.1.3.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 61.835% when pulling 6a23781 on dbmdz:bottompanel-in-fullscreen into 099324d on ProjectMirador:2.1.3.

@rsinghal rsinghal changed the base branch from 2.1.3 to 2.1.4 February 9, 2017 16:33
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 61.511% when pulling 4388825 on dbmdz:bottompanel-in-fullscreen into 993b08e on ProjectMirador:2.1.4.

@aeschylus
Copy link
Collaborator

Let's take this up on the call this Thursday. I remember this was requested at one point, so perhaps it's worth making this a configuration option.

Additionally, it might do to improve the responsiveness of the bottom panel so that it isn't so tiny on large displays. The size also causes many more thumbnails to need to load than may really be necessary for the user to navigate right off the bat.

For now I'll mark this as a won't fix.

@aeschylus aeschylus closed this Feb 22, 2017
@jbaiter jbaiter deleted the bottompanel-in-fullscreen branch January 18, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants